Commit 19040c0b authored Mar 24, 2011 by Mike Snitzer Committed by Alasdair G Kergon Mar 24, 2011

dm mpath: fail message ioctl if specified path is not valid



Fail the reinstate_path and fail_path message ioctl if the specified
path is not valid.

The message ioctl would succeed for the 'reinistate_path' and
'fail_path' messages even if action was not taken because the
specified device was not a valid path of the multipath device.

Before, when /dev/vdb is not a path of mpathb:
$ dmsetup message mpathb 0 reinstate_path /dev/vdb
$ echo $?
0

After:
$ dmsetup message mpathb 0 reinstate_path /dev/vdb
device-mapper: message ioctl failed: Invalid argument
Command failed
$ echo $?
1

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent f8681205

drivers/md/dm-mpath.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1065,7 +1065,7 @@ out:
		static int action_dev(struct multipath m, struct dm_dev dev,
		action_fn action)
		{
		int r = 0;
		int r = -EINVAL;
		struct pgpath *pgpath;
		struct priority_group *pg;

		@@ -1669,7 +1669,7 @@ out:
		---------------------------------------------------------------/
		static struct target_type multipath_target = {
		.name = "multipath",
		.version = {1, 2, 0},
		.version = {1, 3, 0},
		.module = THIS_MODULE,
		.ctr = multipath_ctr,
		.dtr = multipath_dtr,

Admin message