Commit 1901762f authored Sep 29, 2017 by Dick Kennedy Committed by Martin K. Petersen Oct 02, 2017

scsi: lpfc: fix pci hot plug crash in timer management routines



During pci hot plug, the kernel crashes in timer management code.

The sli4 remove_one handler is not stoping the timers as it starts to
remove the port so that it can be swapped.

Fix: Stop the timers early in the handler routine.

Note: Fix in SLI-4 only. SLI-3 already stopped the timers properly.

Cc: <stable@vger.kernel.org> # 4.12+
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 85ce6b42

drivers/scsi/lpfc/lpfc_init.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -11419,6 +11419,7 @@ lpfc_pci_remove_one_s4(struct pci_dev *pdev)
		lpfc_debugfs_terminate(vport);
		lpfc_sli4_hba_unset(phba);

		lpfc_stop_hba_timers(phba);
		spin_lock_irq(&phba->hbalock);
		list_del_init(&vport->listentry);
		spin_unlock_irq(&phba->hbalock);

Admin message