gpio: zx: make explicitly non-modular (18fb0a98) · Commits · 戴 / test

The Kconfig currently controlling compilation of this code is: config GPIO_ZX bool "ZTE ZX GPIO support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Jun Nie <jun.nie@linaro.org> Cc: linux-gpio@vger.kernel.org Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-zx.c

+6 −8

Original line number	Diff line number	Diff line
		/*
		* ZTE ZX296702 GPIO driver
		*
		* Author: Jun Nie <jun.nie@linaro.org>
		*
		* Copyright (C) 2015 Linaro Ltd.
		*
		* This program is free software; you can redistribute it and/or modify
		@@ -10,7 +14,7 @@
		#include <linux/errno.h>
		#include <linux/gpio/driver.h>
		#include <linux/irqchip/chained_irq.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/of.h>
		#include <linux/pinctrl/consumer.h>
		#include <linux/platform_device.h>
		@@ -282,7 +286,6 @@ static const struct of_device_id zx_gpio_match[] = {
		},
		{ },
		};
		MODULE_DEVICE_TABLE(of, zx_gpio_match);

		static struct platform_driver zx_gpio_driver = {
		.probe = zx_gpio_probe,
		@@ -291,9 +294,4 @@ static struct platform_driver zx_gpio_driver = {
		.of_match_table = of_match_ptr(zx_gpio_match),
		},
		};

		module_platform_driver(zx_gpio_driver)

		MODULE_AUTHOR("Jun Nie <jun.nie@linaro.org>");
		MODULE_DESCRIPTION("ZTE ZX296702 GPIO driver");
		MODULE_LICENSE("GPL");
		builtin_platform_driver(zx_gpio_driver)

Admin message