Commit 18f5ed36 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: fireworks/firewire-lib: add support for recent firmware quirk 



Fireworks uses TSB43CB43(IceLynx-Micro) as its IEC 61883-1/6 interface.
This chip includes ARM7 core, and loads and runs program. The firmware
is stored in on-board memory and loaded every powering-on from it.

Echo Audio ships several versions of firmwares for each model. These
firmwares have each quirk and the quirk changes a sequence of packets.

As long as I investigated, AudioFire2/AudioFire4/AudioFirePre8 have a
quirk to transfer a first packet with 0x02 in its dbc field. This causes
ALSA Fireworks driver to detect discontinuity. In this case, firmware
version 5.7.0, 5.7.3 and 5.8.0 are used.

Payload  CIP      CIP
quadlets header1  header2
02       00050002 90ffffff <-
42       0005000a 90013000
42       00050012 90014400
42       0005001a 90015800
02       0005001a 90ffffff
42       00050022 90019000
42       0005002a 9001a400
42       00050032 9001b800
02       00050032 90ffffff
42       0005003a 9001d000
42       00050042 9001e400
42       0005004a 9001f800
02       0005004a 90ffffff
(AudioFire2 with firmware version 5.7.)

$ dmesg
snd-fireworks fw1.0: Detect discontinuity of CIP: 00 02

These models, AudioFire8 (since Jul 2009 ) and Gibson Robot Interface
Pack series uses the same ARM binary as their firmware. Thus, this
quirk may be observed among them.

This commit adds a new member for AMDTP structure. This member represents
the value of dbc field in a first AMDTP packet. Drivers can set it with
a preferred value according to model's quirk.

Tested-by: default avatarJohannes Oertei <johannes.oertel@uni-due.de>
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c85523d1

sound/firewire/amdtp.c

+3 −2
Original line number Diff line number Diff line
@@ -740,8 +740,9 @@ static int handle_in_packet(struct amdtp_stream *s, 
	    s->data_block_counter != UINT_MAX)

		data_block_counter = s->data_block_counter;



	if (((s->flags & CIP_SKIP_DBC_ZERO_CHECK) && data_block_counter == 0) ||

	    (s->data_block_counter == UINT_MAX)) {

	if (((s->flags & CIP_SKIP_DBC_ZERO_CHECK) &&

	     data_block_counter == s->tx_first_dbc) ||

	    s->data_block_counter == UINT_MAX) {

		lost = false;

	} else if (!(s->flags & CIP_DBC_IS_END_EVENT)) {

		lost = data_block_counter != s->data_block_counter;

sound/firewire/amdtp.h

+2 −0
Original line number Diff line number Diff line
@@ -157,6 +157,8 @@ struct amdtp_stream { 


	/* quirk: fixed interval of dbc between previos/current packets. */

	unsigned int tx_dbc_interval;

	/* quirk: indicate the value of dbc field in a first packet. */

	unsigned int tx_first_dbc;



	bool callbacked;

	wait_queue_head_t callback_wait;

sound/firewire/fireworks/fireworks.c

+8 −0
Original line number Diff line number Diff line
@@ -248,8 +248,16 @@ efw_probe(struct fw_unit *unit, 
	err = get_hardware_info(efw);

	if (err < 0)

		goto error;

	/* AudioFire8 (since 2009) and AudioFirePre8 */

	if (entry->model_id == MODEL_ECHO_AUDIOFIRE_9)

		efw->is_af9 = true;

	/* These models uses the same firmware. */

	if (entry->model_id == MODEL_ECHO_AUDIOFIRE_2 ||

	    entry->model_id == MODEL_ECHO_AUDIOFIRE_4 ||

	    entry->model_id == MODEL_ECHO_AUDIOFIRE_9 ||

	    entry->model_id == MODEL_GIBSON_RIP ||

	    entry->model_id == MODEL_GIBSON_GOLDTOP)

		efw->is_fireworks3 = true;



	snd_efw_proc_init(efw);

sound/firewire/fireworks/fireworks.h

+1 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ struct snd_efw { 


	/* for quirks */

	bool is_af9;

	bool is_fireworks3;

	u32 firmware_version;



	unsigned int midi_in_ports;

sound/firewire/fireworks/fireworks_stream.c

+9 −0
Original line number Diff line number Diff line
@@ -172,6 +172,15 @@ int snd_efw_stream_init_duplex(struct snd_efw *efw) 
	efw->tx_stream.flags |= CIP_DBC_IS_END_EVENT;

	/* Fireworks reset dbc at bus reset. */

	efw->tx_stream.flags |= CIP_SKIP_DBC_ZERO_CHECK;

	/*

	 * But Recent firmwares starts packets with non-zero dbc.

	 * Driver version 5.7.6 installs firmware version 5.7.3.

	 */

	if (efw->is_fireworks3 &&

	    (efw->firmware_version == 0x5070000 ||

	     efw->firmware_version == 0x5070300 ||

	     efw->firmware_version == 0x5080000))

		efw->tx_stream.tx_first_dbc = 0x02;

	/* AudioFire9 always reports wrong dbs. */

	if (efw->is_af9)

		efw->tx_stream.flags |= CIP_WRONG_DBS;

CRA Git | Maintained and supported by SUSTech CRA and CCSE