staging: comedi: amplc_dio200: Remove function clk_sce() (18e75e32) · Commits · 戴 / test

Remove function clk_sce as all it does is call clk_gat_sce. Modify call site of clk_sce to call clk_gat_sce instead. Issue found with Coccinelle. Signed-off-by:

Nishka Dasgupta <nishkadg.linux@gmail.com> Reviewed-by:

Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20190701070025.3838-1-nishkadg.linux@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/amplc_dio200_common.c

+1 −7

Original line number	Diff line number	Diff line
		@@ -46,12 +46,6 @@ static unsigned char clk_gat_sce(unsigned int which, unsigned int chan,
		((source & 030) << 3) \| (source & 007);
		}

		static unsigned char clk_sce(unsigned int which, unsigned int chan,
		unsigned int source)
		{
		return clk_gat_sce(which, chan, source);
		}

		static unsigned char gat_sce(unsigned int which, unsigned int chan,
		unsigned int source)
		{
		@@ -500,7 +494,7 @@ static void dio200_subdev_8254_set_clock_src(struct comedi_device *dev,
		unsigned int offset = dio200_subdev_8254_offset(dev, s);

		dio200_write8(dev, DIO200_CLK_SCE(offset >> 3),
		clk_sce((offset >> 2) & 1, chan, src));
		clk_gat_sce((offset >> 2) & 1, chan, src));
		}

		static int dio200_subdev_8254_config(struct comedi_device *dev,

Admin message