Commit 18e643cd authored May 09, 2020 by Samuel Zou Committed by Michael S. Tsirkin Jun 04, 2020

vdpasim: Fix some coccinelle warnings

Fix below warnings reported by coccicheck:

drivers/vdpa/vdpa_sim/vdpa_sim.c:104:1-10: WARNING: Assignment of 0/1 to bool variable
drivers/vdpa/vdpa_sim/vdpa_sim.c:164:7-11: WARNING: Unsigned expression compared with zero: read <= 0
drivers/vdpa/vdpa_sim/vdpa_sim.c:169:7-12: WARNING: Unsigned expression compared with zero: write <= 0

1. The 'ready' variable in vdpasim_virtqueue struct is bool type.
It is better to initialize vq->ready to false

2. Modify 'read' and 'write' variables type from size_t to ssize_t.
And preserve the reverse christmas tree ordering of local variables.

Fixes: 2c53d0f6 ("vdpasim: vDPA device simulator")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1588990802-28451-1-git-send-email-zou_wei@huawei.com

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent 7dd793f3

drivers/vdpa/vdpa_sim/vdpa_sim.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)

		static void vdpasim_vq_reset(struct vdpasim_virtqueue *vq)
		{
		vq->ready = 0;
		vq->ready = false;
		vq->desc_addr = 0;
		vq->driver_addr = 0;
		vq->device_addr = 0;
		@@ -131,9 +131,10 @@ static void vdpasim_work(struct work_struct *work)
		vdpasim, work);
		struct vdpasim_virtqueue *txq = &vdpasim->vqs[1];
		struct vdpasim_virtqueue *rxq = &vdpasim->vqs[0];
		size_t read, write, total_write;
		int err;
		ssize_t read, write;
		size_t total_write;
		int pkts = 0;
		int err;

		spin_lock(&vdpasim->lock);

Admin message