Commit 18ddbaa0 authored by Catalin Marinas's avatar Catalin Marinas
Browse files

arm64: mte: ptrace: Add PTRACE_{PEEK,POKE}MTETAGS support 



Add support for bulk setting/getting of the MTE tags in a tracee's
address space at 'addr' in the ptrace() syscall prototype. 'data' points
to a struct iovec in the tracer's address space with iov_base
representing the address of a tracer's buffer of length iov_len. The
tags to be copied to/from the tracer's buffer are stored as one tag per
byte.

On successfully copying at least one tag, ptrace() returns 0 and updates
the tracer's iov_len with the number of tags copied. In case of error,
either -EIO or -EFAULT is returned, trying to follow the ptrace() man
page.

Note that the tag copying functions are not performance critical,
therefore they lack optimisations found in typical memory copy routines.

Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Alan Hayward <Alan.Hayward@arm.com>
Cc: Luis Machado <luis.machado@linaro.org>
Cc: Omair Javaid <omair.javaid@linaro.org>
parent 93f067f6

arch/arm64/include/asm/mte.h

+17 −0
Original line number Diff line number Diff line
@@ -5,6 +5,11 @@ 
#ifndef __ASM_MTE_H

#define __ASM_MTE_H



#define MTE_GRANULE_SIZE	UL(16)

#define MTE_GRANULE_MASK	(~(MTE_GRANULE_SIZE - 1))

#define MTE_TAG_SHIFT		56

#define MTE_TAG_SIZE		4



#ifndef __ASSEMBLY__



#include <linux/page-flags.h>
@@ -12,6 +17,10 @@ 
#include <asm/pgtable-types.h>



void mte_clear_page_tags(void *addr);

unsigned long mte_copy_tags_from_user(void *to, const void __user *from,

				      unsigned long n);

unsigned long mte_copy_tags_to_user(void __user *to, void *from,

				    unsigned long n);



#ifdef CONFIG_ARM64_MTE
@@ -25,6 +34,8 @@ void mte_thread_switch(struct task_struct *next); 
void mte_suspend_exit(void);

long set_mte_ctrl(struct task_struct *task, unsigned long arg);

long get_mte_ctrl(struct task_struct *task);

int mte_ptrace_copy_tags(struct task_struct *child, long request,

			 unsigned long addr, unsigned long data);



#else
@@ -54,6 +65,12 @@ static inline long get_mte_ctrl(struct task_struct *task) 
{

	return 0;

}

static inline int mte_ptrace_copy_tags(struct task_struct *child,

				       long request, unsigned long addr,

				       unsigned long data)

{

	return -EIO;

}



#endif

arch/arm64/include/uapi/asm/ptrace.h

+3 −0
Original line number Diff line number Diff line
@@ -76,6 +76,9 @@ 
/* syscall emulation path in ptrace */

#define PTRACE_SYSEMU		  31

#define PTRACE_SYSEMU_SINGLESTEP  32

/* MTE allocation tag access */

#define PTRACE_PEEKMTETAGS	  33

#define PTRACE_POKEMTETAGS	  34



#ifndef __ASSEMBLY__

arch/arm64/kernel/mte.c

+138 −0
Original line number Diff line number Diff line
@@ -4,14 +4,18 @@ 
 */



#include <linux/bitops.h>

#include <linux/kernel.h>

#include <linux/mm.h>

#include <linux/prctl.h>

#include <linux/sched.h>

#include <linux/sched/mm.h>

#include <linux/string.h>

#include <linux/thread_info.h>

#include <linux/uio.h>



#include <asm/cpufeature.h>

#include <asm/mte.h>

#include <asm/ptrace.h>

#include <asm/sysreg.h>



void mte_sync_tags(pte_t *ptep, pte_t pte)
@@ -179,3 +183,137 @@ long get_mte_ctrl(struct task_struct *task) 


	return ret;

}



/*

 * Access MTE tags in another process' address space as given in mm. Update

 * the number of tags copied. Return 0 if any tags copied, error otherwise.

 * Inspired by __access_remote_vm().

 */

static int __access_remote_tags(struct mm_struct *mm, unsigned long addr,

				struct iovec *kiov, unsigned int gup_flags)

{

	struct vm_area_struct *vma;

	void __user *buf = kiov->iov_base;

	size_t len = kiov->iov_len;

	int ret;

	int write = gup_flags & FOLL_WRITE;



	if (!access_ok(buf, len))

		return -EFAULT;



	if (mmap_read_lock_killable(mm))

		return -EIO;



	while (len) {

		unsigned long tags, offset;

		void *maddr;

		struct page *page = NULL;



		ret = get_user_pages_remote(mm, addr, 1, gup_flags, &page,

					    &vma, NULL);

		if (ret <= 0)

			break;



		/*

		 * Only copy tags if the page has been mapped as PROT_MTE

		 * (PG_mte_tagged set). Otherwise the tags are not valid and

		 * not accessible to user. Moreover, an mprotect(PROT_MTE)

		 * would cause the existing tags to be cleared if the page

		 * was never mapped with PROT_MTE.

		 */

		if (!test_bit(PG_mte_tagged, &page->flags)) {

			ret = -EOPNOTSUPP;

			put_page(page);

			break;

		}



		/* limit access to the end of the page */

		offset = offset_in_page(addr);

		tags = min(len, (PAGE_SIZE - offset) / MTE_GRANULE_SIZE);



		maddr = page_address(page);

		if (write) {

			tags = mte_copy_tags_from_user(maddr + offset, buf, tags);

			set_page_dirty_lock(page);

		} else {

			tags = mte_copy_tags_to_user(buf, maddr + offset, tags);

		}

		put_page(page);



		/* error accessing the tracer's buffer */

		if (!tags)

			break;



		len -= tags;

		buf += tags;

		addr += tags * MTE_GRANULE_SIZE;

	}

	mmap_read_unlock(mm);



	/* return an error if no tags copied */

	kiov->iov_len = buf - kiov->iov_base;

	if (!kiov->iov_len) {

		/* check for error accessing the tracee's address space */

		if (ret <= 0)

			return -EIO;

		else

			return -EFAULT;

	}



	return 0;

}



/*

 * Copy MTE tags in another process' address space at 'addr' to/from tracer's

 * iovec buffer. Return 0 on success. Inspired by ptrace_access_vm().

 */

static int access_remote_tags(struct task_struct *tsk, unsigned long addr,

			      struct iovec *kiov, unsigned int gup_flags)

{

	struct mm_struct *mm;

	int ret;



	mm = get_task_mm(tsk);

	if (!mm)

		return -EPERM;



	if (!tsk->ptrace || (current != tsk->parent) ||

	    ((get_dumpable(mm) != SUID_DUMP_USER) &&

	     !ptracer_capable(tsk, mm->user_ns))) {

		mmput(mm);

		return -EPERM;

	}



	ret = __access_remote_tags(mm, addr, kiov, gup_flags);

	mmput(mm);



	return ret;

}



int mte_ptrace_copy_tags(struct task_struct *child, long request,

			 unsigned long addr, unsigned long data)

{

	int ret;

	struct iovec kiov;

	struct iovec __user *uiov = (void __user *)data;

	unsigned int gup_flags = FOLL_FORCE;



	if (!system_supports_mte())

		return -EIO;



	if (get_user(kiov.iov_base, &uiov->iov_base) ||

	    get_user(kiov.iov_len, &uiov->iov_len))

		return -EFAULT;



	if (request == PTRACE_POKEMTETAGS)

		gup_flags |= FOLL_WRITE;



	/* align addr to the MTE tag granule */

	addr &= MTE_GRANULE_MASK;



	ret = access_remote_tags(child, addr, &kiov, gup_flags);

	if (!ret)

		ret = put_user(kiov.iov_len, &uiov->iov_len);



	return ret;

}

arch/arm64/kernel/ptrace.c

+7 −0
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ 
#include <asm/cpufeature.h>

#include <asm/debug-monitors.h>

#include <asm/fpsimd.h>

#include <asm/mte.h>

#include <asm/pointer_auth.h>

#include <asm/stacktrace.h>

#include <asm/syscall.h>
@@ -1691,6 +1692,12 @@ const struct user_regset_view *task_user_regset_view(struct task_struct *task) 
long arch_ptrace(struct task_struct *child, long request,

		 unsigned long addr, unsigned long data)

{

	switch (request) {

	case PTRACE_PEEKMTETAGS:

	case PTRACE_POKEMTETAGS:

		return mte_ptrace_copy_tags(child, request, addr, data);

	}



	return ptrace_request(child, request, addr, data);

}

arch/arm64/lib/mte.S

+53 −0
Original line number Diff line number Diff line
@@ -4,7 +4,9 @@ 
 */

#include <linux/linkage.h>



#include <asm/alternative.h>

#include <asm/assembler.h>

#include <asm/mte.h>

#include <asm/page.h>

#include <asm/sysreg.h>
@@ -51,3 +53,54 @@ SYM_FUNC_START(mte_copy_page_tags) 
	b.ne	1b

	ret

SYM_FUNC_END(mte_copy_page_tags)



/*

 * Read tags from a user buffer (one tag per byte) and set the corresponding

 * tags at the given kernel address. Used by PTRACE_POKEMTETAGS.

 *   x0 - kernel address (to)

 *   x1 - user buffer (from)

 *   x2 - number of tags/bytes (n)

 * Returns:

 *   x0 - number of tags read/set

 */

SYM_FUNC_START(mte_copy_tags_from_user)

	mov	x3, x1

	cbz	x2, 2f

1:

	uao_user_alternative 2f, ldrb, ldtrb, w4, x1, 0

	lsl	x4, x4, #MTE_TAG_SHIFT

	stg	x4, [x0], #MTE_GRANULE_SIZE

	add	x1, x1, #1

	subs	x2, x2, #1

	b.ne	1b



	// exception handling and function return

2:	sub	x0, x1, x3		// update the number of tags set

	ret

SYM_FUNC_END(mte_copy_tags_from_user)



/*

 * Get the tags from a kernel address range and write the tag values to the

 * given user buffer (one tag per byte). Used by PTRACE_PEEKMTETAGS.

 *   x0 - user buffer (to)

 *   x1 - kernel address (from)

 *   x2 - number of tags/bytes (n)

 * Returns:

 *   x0 - number of tags read/set

 */

SYM_FUNC_START(mte_copy_tags_to_user)

	mov	x3, x0

	cbz	x2, 2f

1:

	ldg	x4, [x1]

	ubfx	x4, x4, #MTE_TAG_SHIFT, #MTE_TAG_SIZE

	uao_user_alternative 2f, strb, sttrb, w4, x0, 0

	add	x0, x0, #1

	add	x1, x1, #MTE_GRANULE_SIZE

	subs	x2, x2, #1

	b.ne	1b



	// exception handling and function return

2:	sub	x0, x0, x3		// update the number of tags copied

	ret

SYM_FUNC_END(mte_copy_tags_to_user)

CRA Git | Maintained and supported by SUSTech CRA and CCSE