Commit 18d0cdfd authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: normalize status values in packet callbacks 



core-transaction.c transmit_complete_callback() and close_transaction()
expect packet callback status to be an ACK or RCODE, and ACKs get
translated to RCODEs for transaction callbacks.

An old comment on the packet callback API (been there from the initial
submission of the stack) and the dummy_driver implementation of
send_request/send_response deviated from this as they also included
-ERRNO in the range of status values.

Let's narrow status values down to ACK and RCODE to prevent surprises.
RCODE_CANCELLED is chosen as the dummy_driver's RCODE as its meaning of
"transaction timed out" comes closest to what happens when a transaction
coincides with card removal.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 80792d18

drivers/firewire/core-card.c

+2 −2
Original line number Diff line number Diff line
@@ -570,12 +570,12 @@ static int dummy_set_config_rom(struct fw_card *card, 


static void dummy_send_request(struct fw_card *card, struct fw_packet *packet)

{

	packet->callback(packet, card, -ENODEV);

	packet->callback(packet, card, RCODE_CANCELLED);

}



static void dummy_send_response(struct fw_card *card, struct fw_packet *packet)

{

	packet->callback(packet, card, -ENODEV);

	packet->callback(packet, card, RCODE_CANCELLED);

}



static int dummy_cancel_packet(struct fw_card *card, struct fw_packet *packet)

drivers/firewire/core-transaction.c

+4 −1
Original line number Diff line number Diff line
@@ -310,7 +310,10 @@ static int allocate_tlabel(struct fw_card *card) 
 * After the transaction is completed successfully or unsuccessfully, the

 * @callback will be called.  Among its parameters is the response code which

 * is either one of the rcodes per IEEE 1394 or, in case of internal errors,

 * the firewire-core specific %RCODE_SEND_ERROR.

 * the firewire-core specific %RCODE_SEND_ERROR.  The other firewire-core

 * specific rcodes (%RCODE_CANCELLED, %RCODE_BUSY, %RCODE_GENERATION,

 * %RCODE_NO_ACK) denote transaction timeout, busy responder, stale request

 * generation, or missing ACK respectively.

 *

 * Note some timing corner cases:  fw_send_request() may complete much earlier

 * than when the request packet actually hits the wire.  On the other hand,

include/linux/firewire.h

+4 −4
Original line number Diff line number Diff line
@@ -285,10 +285,10 @@ struct fw_packet { 
	u32 timestamp;



	/*

	 * This callback is called when the packet transmission has

	 * completed; for successful transmission, the status code is

	 * the ack received from the destination, otherwise it's a

	 * negative errno: ENOMEM, ESTALE, ETIMEDOUT, ENODEV, EIO.

	 * This callback is called when the packet transmission has completed.

	 * For successful transmission, the status code is the ack received

	 * from the destination.  Otherwise it is one of the juju-specific

	 * rcodes:  RCODE_SEND_ERROR, _CANCELLED, _BUSY, _GENERATION, _NO_ACK.

	 * The callback can be called from tasklet context and thus

	 * must never block.

	 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE