Commit 18b5992c authored by Ben Widawsky's avatar Ben Widawsky Committed by Daniel Vetter
Browse files

drm/i915: Calculate PSR register offsets from base + gen 



Future generations will be changing these registers (thanks to design
for giving us an early heads up). To help abstract, create the
definition of the base of the register block, and define all registers
relative to that.

Design has promised to not change the offsets relative to the base.

v2: Also change IS_HASWELL checks to HAS_PSR

CC: Rodrigo Vivi <rodrigo.vivi@gmail.com>
CC: Intel GFX <intel-gfx@lists.freedesktop.org>
Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 50003939

drivers/gpu/drm/i915/i915_debugfs.c

+5 −4
Original line number Diff line number Diff line
@@ -1668,9 +1668,10 @@ static int i915_edp_psr_status(struct seq_file *m, void *data) 
	struct drm_i915_private *dev_priv = dev->dev_private;

	u32 psrstat, psrperf;



	if (!IS_HASWELL(dev)) {

	if (!HAS_PSR(dev)) {

		seq_puts(m, "PSR not supported on this platform\n");

	} else if (IS_HASWELL(dev) && I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE) {

	} else if (HAS_PSR(dev) &&

		   I915_READ(EDP_PSR_CTL(dev)) & EDP_PSR_ENABLE) {

		seq_puts(m, "PSR enabled\n");

	} else {

		seq_puts(m, "PSR disabled: ");
@@ -1712,7 +1713,7 @@ static int i915_edp_psr_status(struct seq_file *m, void *data) 
		return 0;

	}



	psrstat = I915_READ(EDP_PSR_STATUS_CTL);

	psrstat = I915_READ(EDP_PSR_STATUS_CTL(dev));



	seq_puts(m, "PSR Current State: ");

	switch (psrstat & EDP_PSR_STATUS_STATE_MASK) {
@@ -1784,7 +1785,7 @@ static int i915_edp_psr_status(struct seq_file *m, void *data) 
	seq_printf(m, "Idle Count: %u\n",

		   psrstat & EDP_PSR_STATUS_IDLE_MASK);



	psrperf = (I915_READ(EDP_PSR_PERF_CNT)) & EDP_PSR_PERF_CNT_MASK;

	psrperf = (I915_READ(EDP_PSR_PERF_CNT(dev))) & EDP_PSR_PERF_CNT_MASK;

	seq_printf(m, "Performance Counter: %u\n", psrperf);



	return 0;

drivers/gpu/drm/i915/i915_drv.h

+1 −0
Original line number Diff line number Diff line
@@ -1684,6 +1684,7 @@ struct drm_i915_file_private { 
#define HAS_DDI(dev)		(INTEL_INFO(dev)->has_ddi)

#define HAS_POWER_WELL(dev)	(IS_HASWELL(dev))

#define HAS_FPGA_DBG_UNCLAIMED(dev)	(INTEL_INFO(dev)->has_fpga_dbg)

#define HAS_PSR(dev)		(IS_HASWELL(dev))



#define INTEL_PCH_DEVICE_ID_MASK		0xff00

#define INTEL_PCH_IBX_DEVICE_ID_TYPE		0x3b00

drivers/gpu/drm/i915/i915_reg.h

+11 −10
Original line number Diff line number Diff line
@@ -1848,7 +1848,8 @@ 
#define VSYNCSHIFT(trans) _TRANSCODER(trans, _VSYNCSHIFT_A, _VSYNCSHIFT_B)



/* HSW eDP PSR registers */

#define EDP_PSR_CTL				0x64800

#define EDP_PSR_BASE(dev)			0x64800

#define EDP_PSR_CTL(dev)			(EDP_PSR_BASE(dev) + 0)

#define   EDP_PSR_ENABLE			(1<<31)

#define   EDP_PSR_LINK_DISABLE			(0<<27)

#define   EDP_PSR_LINK_STANDBY			(1<<27)
@@ -1871,16 +1872,16 @@ 
#define   EDP_PSR_TP1_TIME_0us			(3<<4)

#define   EDP_PSR_IDLE_FRAME_SHIFT		0



#define EDP_PSR_AUX_CTL			0x64810

#define EDP_PSR_AUX_DATA1		0x64814

#define EDP_PSR_AUX_CTL(dev)			(EDP_PSR_BASE(dev) + 0x10)

#define EDP_PSR_AUX_DATA1(dev)			(EDP_PSR_BASE(dev) + 0x14)

#define   EDP_PSR_DPCD_COMMAND		0x80060000

#define EDP_PSR_AUX_DATA2		0x64818

#define EDP_PSR_AUX_DATA2(dev)			(EDP_PSR_BASE(dev) + 0x18)

#define   EDP_PSR_DPCD_NORMAL_OPERATION	(1<<24)

#define EDP_PSR_AUX_DATA3		0x6481c

#define EDP_PSR_AUX_DATA4		0x64820

#define EDP_PSR_AUX_DATA5		0x64824

#define EDP_PSR_AUX_DATA3(dev)			(EDP_PSR_BASE(dev) + 0x1c)

#define EDP_PSR_AUX_DATA4(dev)			(EDP_PSR_BASE(dev) + 0x20)

#define EDP_PSR_AUX_DATA5(dev)			(EDP_PSR_BASE(dev) + 0x24)



#define EDP_PSR_STATUS_CTL			0x64840

#define EDP_PSR_STATUS_CTL(dev)			(EDP_PSR_BASE(dev) + 0x40)

#define   EDP_PSR_STATUS_STATE_MASK		(7<<29)

#define   EDP_PSR_STATUS_STATE_IDLE		(0<<29)

#define   EDP_PSR_STATUS_STATE_SRDONACK		(1<<29)
@@ -1904,10 +1905,10 @@ 
#define   EDP_PSR_STATUS_SENDING_TP1		(1<<4)

#define   EDP_PSR_STATUS_IDLE_MASK		0xf



#define EDP_PSR_PERF_CNT		0x64844

#define EDP_PSR_PERF_CNT(dev)		(EDP_PSR_BASE(dev) + 0x44)

#define   EDP_PSR_PERF_CNT_MASK		0xffffff



#define EDP_PSR_DEBUG_CTL		0x64860

#define EDP_PSR_DEBUG_CTL(dev)		(EDP_PSR_BASE(dev) + 0x60)

#define   EDP_PSR_DEBUG_MASK_LPSP	(1<<27)

#define   EDP_PSR_DEBUG_MASK_MEMUP	(1<<26)

#define   EDP_PSR_DEBUG_MASK_HPD	(1<<25)

drivers/gpu/drm/i915/intel_dp.c

+11 −10
Original line number Diff line number Diff line
@@ -1496,10 +1496,10 @@ static bool intel_edp_is_psr_enabled(struct drm_device *dev) 
{

	struct drm_i915_private *dev_priv = dev->dev_private;



	if (!IS_HASWELL(dev))

	if (!HAS_PSR(dev))

		return false;



	return I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE;

	return I915_READ(EDP_PSR_CTL(dev)) & EDP_PSR_ENABLE;

}



static void intel_edp_psr_write_vsc(struct intel_dp *intel_dp,
@@ -1549,7 +1549,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp) 
	intel_edp_psr_write_vsc(intel_dp, &psr_vsc);



	/* Avoid continuous PSR exit by masking memup and hpd */

	I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP |

	I915_WRITE(EDP_PSR_DEBUG_CTL(dev), EDP_PSR_DEBUG_MASK_MEMUP |

		   EDP_PSR_DEBUG_MASK_HPD);



	intel_dp->psr_setup_done = true;
@@ -1574,9 +1574,9 @@ static void intel_edp_psr_enable_sink(struct intel_dp *intel_dp) 
					    DP_PSR_MAIN_LINK_ACTIVE);



	/* Setup AUX registers */

	I915_WRITE(EDP_PSR_AUX_DATA1, EDP_PSR_DPCD_COMMAND);

	I915_WRITE(EDP_PSR_AUX_DATA2, EDP_PSR_DPCD_NORMAL_OPERATION);

	I915_WRITE(EDP_PSR_AUX_CTL,

	I915_WRITE(EDP_PSR_AUX_DATA1(dev), EDP_PSR_DPCD_COMMAND);

	I915_WRITE(EDP_PSR_AUX_DATA2(dev), EDP_PSR_DPCD_NORMAL_OPERATION);

	I915_WRITE(EDP_PSR_AUX_CTL(dev),

		   DP_AUX_CH_CTL_TIME_OUT_400us |

		   (msg_size << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |

		   (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
@@ -1599,7 +1599,7 @@ static void intel_edp_psr_enable_source(struct intel_dp *intel_dp) 
	} else

		val |= EDP_PSR_LINK_DISABLE;



	I915_WRITE(EDP_PSR_CTL, val |

	I915_WRITE(EDP_PSR_CTL(dev), val |

		   EDP_PSR_MIN_LINK_ENTRY_TIME_8_LINES |

		   max_sleep_time << EDP_PSR_MAX_SLEEP_TIME_SHIFT |

		   idle_frames << EDP_PSR_IDLE_FRAME_SHIFT |
@@ -1616,7 +1616,7 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp) 
	struct drm_i915_gem_object *obj = to_intel_framebuffer(crtc->fb)->obj;

	struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;



	if (!IS_HASWELL(dev)) {

	if (!HAS_PSR(dev)) {

		DRM_DEBUG_KMS("PSR not supported on this platform\n");

		dev_priv->no_psr_reason = PSR_NO_SOURCE;

		return false;
@@ -1720,10 +1720,11 @@ void intel_edp_psr_disable(struct intel_dp *intel_dp) 
	if (!intel_edp_is_psr_enabled(dev))

		return;



	I915_WRITE(EDP_PSR_CTL, I915_READ(EDP_PSR_CTL) & ~EDP_PSR_ENABLE);

	I915_WRITE(EDP_PSR_CTL(dev),

		   I915_READ(EDP_PSR_CTL(dev)) & ~EDP_PSR_ENABLE);



	/* Wait till PSR is idle */

	if (_wait_for((I915_READ(EDP_PSR_STATUS_CTL) &

	if (_wait_for((I915_READ(EDP_PSR_STATUS_CTL(dev)) &

		       EDP_PSR_STATUS_STATE_MASK) == 0, 2000, 10))

		DRM_ERROR("Timed out waiting for PSR Idle State\n");

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE