Commit 18b4b276 authored by James Morse's avatar James Morse Committed by Rafael J. Wysocki
Browse files

arm64: mm: Remove arch_apei_flush_tlb_one() 



Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on
__set_fixmap() to do the invalidation. Remove it.

Move the IPI-considered-harmful comment to __set_fixmap().

Signed-off-by: default avatarJames Morse <james.morse@arm.com>
Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Tested-by: default avatarTyler Baicar <tbaicar@codeaurora.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: All applicable <stable@vger.kernel.org>
parent 520e18a5

arch/arm64/include/asm/acpi.h

+0 −12
Original line number Diff line number Diff line
@@ -126,18 +126,6 @@ static inline const char *acpi_get_enable_method(int cpu) 
 */

#define acpi_disable_cmcff 1

pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);



/*

 * Despite its name, this function must still broadcast the TLB

 * invalidation in order to ensure other CPUs don't end up with junk

 * entries as a result of speculation. Unusually, its also called in

 * IRQ context (ghes_iounmap_irq) so if we ever need to use IPIs for

 * TLB broadcasting, then we're in trouble here.

 */

static inline void arch_apei_flush_tlb_one(unsigned long addr)

{

	flush_tlb_kernel_range(addr, addr + PAGE_SIZE);

}

#endif /* CONFIG_ACPI_APEI */



#ifdef CONFIG_ACPI_NUMA

arch/arm64/mm/mmu.c

+4 −0
Original line number Diff line number Diff line
@@ -778,6 +778,10 @@ void __init early_fixmap_init(void) 
	}

}



/*

 * Unusually, this is also called in IRQ context (ghes_iounmap_irq) so if we

 * ever need to use IPIs for TLB broadcasting, then we're in trouble here.

 */

void __set_fixmap(enum fixed_addresses idx,

			       phys_addr_t phys, pgprot_t flags)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE