gpu: host1x: Don't fail on NULL bo physical address (18b3f5ac) · Commits · 戴 / test

Pinning a Host1x BO currently cannot fail and zero is a valid address for a BO when IOMMU is enabled. To avoid false errors remove checks for NULL BO physical addresses. Fixes: ("gpu: host1x: Add IOMMU support") Signed-off-by:

Mikko Perttunen <mperttunen@nvidia.com> Reviewed-by:

Dmitry Osipenko <digetx@gmail.com> Signed-off-by:

Thierry Reding <treding@nvidia.com>

drivers/gpu/host1x/job.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -197,10 +197,6 @@ static unsigned int pin_job(struct host1x host, struct host1x_job job)
		}

		phys_addr = host1x_bo_pin(reloc->target.bo, &sgt);
		if (!phys_addr) {
		err = -EINVAL;
		goto unpin;
		}

		job->addr_phys[job->num_unpins] = phys_addr;
		job->unpins[job->num_unpins].bo = reloc->target.bo;
		@@ -225,10 +221,6 @@ static unsigned int pin_job(struct host1x host, struct host1x_job job)
		}

		phys_addr = host1x_bo_pin(g->bo, &sgt);
		if (!phys_addr) {
		err = -EINVAL;
		goto unpin;
		}

		if (!IS_ENABLED(CONFIG_TEGRA_HOST1X_FIREWALL) && host->domain) {
		for_each_sg(sgt->sgl, sg, sgt->nents, j)

Admin message