Commit 18a56d69 authored Jul 24, 2019 by Don Brace Committed by Martin K. Petersen Jul 30, 2019

scsi: hpsa: remove printing internal cdb on tag collision



Remove racy printing of internal commands. Completion thread can be
cleaning up the command in parallel.

Reviewed-by: Bader Ali - Saleh <bader.alisaleh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent eeebce18

drivers/scsi/hpsa.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -6091,8 +6091,6 @@ static struct CommandList cmd_tagged_alloc(struct ctlr_info h,
		if (idx != h->last_collision_tag) { /* Print once per tag */
		dev_warn(&h->pdev->dev,
		"%s: tag collision (tag=%d)\n", __func__, idx);
		if (c->scsi_cmd != NULL)
		scsi_print_command(c->scsi_cmd);
		if (scmd)
		scsi_print_command(scmd);
		h->last_collision_tag = idx;

Admin message