Commit 18676ffc authored Jan 30, 2020 by Alexey Dobriyan Committed by Linus Torvalds Jan 31, 2020

fs/binfmt_elf.c: make BAD_ADDR() unlikely

If some mapping goes past TASK_SIZE it will be rejected by kernel which
means no such userspace binaries exist.

Mark every such check as unlikely.

Link: http://lkml.kernel.org/r/20191215124355.GA21124@avx2


Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 03c6d723

fs/binfmt_elf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -97,7 +97,7 @@ static struct linux_binfmt elf_format = {
		.min_coredump = ELF_EXEC_PAGESIZE,
		};

		#define BAD_ADDR(x) ((unsigned long)(x) >= TASK_SIZE)
		#define BAD_ADDR(x) (unlikely((unsigned long)(x) >= TASK_SIZE))

		static int set_brk(unsigned long start, unsigned long end, int prot)
		{

Admin message