[ALSA] sound/: possible cleanups (18612048) · Commits · 戴 / test

Modules: RawMidi Midlevel,HDA generic driver This patch contains the following possible cleanups: - pci/hda/hda_proc.c should #include 'hda_local.h' for including the prototype of it's global function snd_hda_codec_proc_new() - core/rawmidi.c: make the needlessly global and EXPORT_SYMBOL'ed function snd_rawmidi_info() static Signed-off-by:

Adrian Bunk <bunk@stusta.de> Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/core/rawmidi.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -534,7 +534,7 @@ static int snd_rawmidi_release(struct inode inode, struct file file)
		return err;
		}

		int snd_rawmidi_info(struct snd_rawmidi_substream *substream,
		static int snd_rawmidi_info(struct snd_rawmidi_substream *substream,
		struct snd_rawmidi_info *info)
		{
		struct snd_rawmidi *rmidi;
		@@ -1694,7 +1694,6 @@ EXPORT_SYMBOL(snd_rawmidi_transmit_ack);
		EXPORT_SYMBOL(snd_rawmidi_transmit);
		EXPORT_SYMBOL(snd_rawmidi_new);
		EXPORT_SYMBOL(snd_rawmidi_set_ops);
		EXPORT_SYMBOL(snd_rawmidi_info);
		EXPORT_SYMBOL(snd_rawmidi_info_select);
		EXPORT_SYMBOL(snd_rawmidi_kernel_open);
		EXPORT_SYMBOL(snd_rawmidi_kernel_release);

sound/pci/hda/hda_proc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -26,6 +26,7 @@
		#include <linux/pci.h>
		#include <sound/core.h>
		#include "hda_codec.h"
		#include "hda_local.h"

		static const char *get_wid_type_name(unsigned int wid_value)
		{

Admin message