Commit 185556f0 authored Jul 27, 2019 by Jiri Pirko Committed by David S. Miller Jul 27, 2019

mlxsw: spectrum_flower: Forbid to offload mirred redirect on egress



Spectrum ASIC does not support redirection on egress, so refuse to
insert such flows:

$ tc qdisc add dev ens16np1 clsact
$ tc filter add dev ens16np1 egress protocol all pref 1 handle 101 flower skip_sw action mirred egress redirect dev ens16np2
Error: mlxsw_spectrum: Redirect action is not supported on egress.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ca4ac168

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -78,6 +78,11 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
		struct mlxsw_sp_fid *fid;
		u16 fid_index;

		if (mlxsw_sp_acl_block_is_egress_bound(block)) {
		NL_SET_ERR_MSG_MOD(extack, "Redirect action is not supported on egress");
		return -EOPNOTSUPP;
		}

		fid = mlxsw_sp_acl_dummy_fid(mlxsw_sp);
		fid_index = mlxsw_sp_fid_index(fid);
		err = mlxsw_sp_acl_rulei_act_fid_set(mlxsw_sp, rulei,

Admin message