Commit 18380f52 authored Sep 29, 2019 by yu kuai Committed by Andy Shevchenko Oct 10, 2019

platform/x86: classmate-laptop: remove unused variable



Fixes gcc '-Wunused-but-set-variable' warning:

drivers/platform/x86/classmate-laptop.c: In function cmpc_accel_remove_v4:
drivers/platform/x86/classmate-laptop.c:424:21: warning: variable accel
set but not used [-Wunused-but-set-variable]
drivers/platform/x86/classmate-laptop.c: In function cmpc_accel_remove:
drivers/platform/x86/classmate-laptop.c:660:21: warning: variable accel
set but not used [-Wunused-but-set-variable]

In function cmpc_accel_remove_v4 and cmpc_accel_remove, variable accel is
set but not used, so it can be removed. In that case, variable inputdev is
set but not used and can be removed.

Fixes: 7125587d ("classmate-laptop: Add support for Classmate V4 accelerometer.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: yu kuai <yukuai3@huawei.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent da0c9ea1

drivers/platform/x86/classmate-laptop.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -420,12 +420,6 @@ failed_sensitivity:

		static int cmpc_accel_remove_v4(struct acpi_device *acpi)
		{
		struct input_dev *inputdev;
		struct cmpc_accel *accel;

		inputdev = dev_get_drvdata(&acpi->dev);
		accel = dev_get_drvdata(&inputdev->dev);

		device_remove_file(&acpi->dev, &cmpc_accel_sensitivity_attr_v4);
		device_remove_file(&acpi->dev, &cmpc_accel_g_select_attr_v4);
		return cmpc_remove_acpi_notify_device(acpi);
		@@ -656,12 +650,6 @@ failed_file:

		static int cmpc_accel_remove(struct acpi_device *acpi)
		{
		struct input_dev *inputdev;
		struct cmpc_accel *accel;

		inputdev = dev_get_drvdata(&acpi->dev);
		accel = dev_get_drvdata(&inputdev->dev);

		device_remove_file(&acpi->dev, &cmpc_accel_sensitivity_attr);
		return cmpc_remove_acpi_notify_device(acpi);
		}

Admin message