Commit 18365225 authored May 12, 2017 by Michal Hocko Committed by Linus Torvalds May 12, 2017

hwpoison, memcg: forcibly uncharge LRU pages

Laurent Dufour has noticed that hwpoinsoned pages are kept charged.  In
his particular case he has hit a bad_page("page still charged to
cgroup") when onlining a hwpoison page.  While this looks like something
that shouldn't happen in the first place because onlining hwpages and
returning them to the page allocator makes only little sense it shows a
real problem.

hwpoison pages do not get freed usually so we do not uncharge them (at
least not since commit 0a31bc97 ("mm: memcontrol: rewrite uncharge
API")).  Each charge pins memcg (since e8ea14cc ("mm: memcontrol:
take a css reference for each charged page")) as well and so the
mem_cgroup and the associated state will never go away.  Fix this leak
by forcibly uncharging a LRU hwpoisoned page in delete_from_lru_cache().
We also have to tweak uncharge_list because it cannot rely on zero ref
count for these pages.

[akpm@linux-foundation.org: coding-style fixes]
Fixes: 0a31bc97 ("mm: memcontrol: rewrite uncharge API")
Link: http://lkml.kernel.org/r/20170502185507.GB19165@dhcp22.suse.cz


Signed-off-by: Michal Hocko <mhocko@suse.com>
Reported-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Tested-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent deac8429

mm/memcontrol.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5528,7 +5528,7 @@ static void uncharge_list(struct list_head *page_list)
		next = page->lru.next;

		VM_BUG_ON_PAGE(PageLRU(page), page);
		VM_BUG_ON_PAGE(page_count(page), page);
		VM_BUG_ON_PAGE(!PageHWPoison(page) && page_count(page), page);

		if (!page->mem_cgroup)
		continue;

mm/memory-failure.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -539,6 +539,13 @@ static int delete_from_lru_cache(struct page *p)
		*/
		ClearPageActive(p);
		ClearPageUnevictable(p);

		/*
		* Poisoned page might never drop its ref count to 0 so we have
		* to uncharge it manually from its memcg.
		*/
		mem_cgroup_uncharge(p);

		/*
		* drop the page count elevated by isolate_lru_page()
		*/

Admin message