Commit 1830f893 authored Dec 23, 2016 by Jason Wang Committed by David S. Miller Dec 23, 2016

virtio-net: correctly handle XDP_PASS for linearized packets



When XDP_PASS were determined for linearized packets, we try to get
new buffers in the virtqueue and build skbs from them. This is wrong,
we should create skbs based on existed buffers instead. Fixing them by
creating skb based on xdp_page.

With this patch "ping 192.168.100.4 -s 3900 -M do" works for XDP_PASS.

Cc: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 56a86f84

drivers/net/virtio_net.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -578,8 +578,14 @@ static struct sk_buff receive_mergeable(struct net_device dev,
		act = do_xdp_prog(vi, rq, xdp_prog, xdp_page, offset, len);
		switch (act) {
		case XDP_PASS:
		if (unlikely(xdp_page != page))
		__free_pages(xdp_page, 0);
		/* We can only create skb based on xdp_page. */
		if (unlikely(xdp_page != page)) {
		rcu_read_unlock();
		put_page(page);
		head_skb = page_to_skb(vi, rq, xdp_page,
		0, len, PAGE_SIZE);
		return head_skb;
		}
		break;
		case XDP_TX:
		if (unlikely(xdp_page != page))

Admin message