Commit 182a79e0 authored Oct 03, 2018 by Wang Shilong Committed by Theodore Ts'o Oct 03, 2018

ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR



We return most failure of dquota_initialize() except
inode evict, this could make a bit sense, for example
we allow file removal even quota files are broken?

But it dosen't make sense to allow setting project
if quota files etc are broken.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org

parent dc7ac6c4

fs/ext4/ioctl.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -380,7 +380,9 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid)
		brelse(iloc.bh);
		}

		dquot_initialize(inode);
		err = dquot_initialize(inode);
		if (err)
		return err;

		handle = ext4_journal_start(inode, EXT4_HT_QUOTA,
		EXT4_QUOTA_INIT_BLOCKS(sb) +

Admin message