Commit 1821b79d authored Apr 03, 2020 by Colin Ian King Committed by Alexandre Belloni Apr 03, 2020

rtc: ds1307: check for failed memory allocation on wdt



Currently a failed memory allocation will lead to a null pointer
dereference on point wdt.  Fix this by checking for a failed
allocation and just returning.

Addresses-Coverity: ("Dereference null return")
Fixes: fd90d48d ("rtc: ds1307: add support for watchdog timer on ds1388")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200403110437.57420-1-colin.king@canonical.com


Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent 3edf29d9

drivers/rtc/rtc-ds1307.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1673,6 +1673,8 @@ static void ds1307_wdt_register(struct ds1307 *ds1307)
		return;

		wdt = devm_kzalloc(ds1307->dev, sizeof(*wdt), GFP_KERNEL);
		if (!wdt)
		return;

		wdt->info = &ds1388_wdt_info;
		wdt->ops = &ds1388_wdt_ops;

Admin message