Commit 18166c1a authored Aug 19, 2007 by Jean Delvare Committed by Greg Kroah-Hartman Aug 22, 2007

PCI: Run k8t_sound_hostbridge quirk only when needed

The k8t_sound_hostbridge PCI quick fires on my motherboard (Jetway
K8M8MS) while it shouldn't: the on-board sound chip is not disabled
and is working just fine. Looking at the code, I see that we are
running the quirk for two distinct register values (0x88 and 0xc8)
and then clear bit 6 (0x40). However value 0x88 already has bit 6
cleared so this is a no-op. This is what happens on my board. Thus I
believe that the quirk should only be run for register value 0xc8.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent f122392f

drivers/pci/quirks.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -947,7 +947,7 @@ static void k8t_sound_hostbridge(struct pci_dev *dev)
		unsigned char val;

		pci_read_config_byte(dev, 0x50, &val);
		if (val == 0x88 \|\| val == 0xc8) {
		if (val == 0xc8) {
		/* Assume it's probably a MSI-K8T-Neo2Fir */
		printk(KERN_INFO "PCI: MSI-K8T-Neo2Fir, attempting to turn soundcard ON\n");
		pci_write_config_byte(dev, 0x50, val & (~0x40));

Admin message