Commit 18061c17 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Michael Ellerman
Browse files

powerpc/mm: Update PROTFAULT handling in the page fault path 



With radix, we can get page fault with DSISR_PROTFAULT value set in case of
PROT_NONE or autonuma mapping. The PROT_NONE case in handled by the vma check
where we consider the access bad. For autonuma we should fall through and fixup
the access mask correctly.

Without this patch we trigger the WARN_ON() on radix. This code moves that
WARN_ON() within a radix_enabled() check. I also moved the WARN_ON() outside
the if condition making it apply for all type of faults (exec/write/read). It
is also conditionalized for book3s, because BOOK3E can also get a PROTFAULT to
handle the D/I cache sync.

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent c21a493a

arch/powerpc/mm/copro_fault.c

+6 −4
Original line number Diff line number Diff line
@@ -67,10 +67,12 @@ int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea, 
		if (!(vma->vm_flags & (VM_READ | VM_EXEC)))

			goto out_unlock;

		/*

		 * protfault should only happen due to us

		 * mapping a region readonly temporarily. PROT_NONE

		 * is also covered by the VMA check above.

		 * PROT_NONE is covered by the VMA check above.

		 * and hash should get a NOHPTE fault instead of

		 * a PROTFAULT in case fixup is needed for things

		 * like autonuma.

		 */

		if (!radix_enabled())

			WARN_ON_ONCE(dsisr & DSISR_PROTFAULT);

	}

arch/powerpc/mm/fault.c

+33 −10
Original line number Diff line number Diff line
@@ -418,15 +418,6 @@ good_area: 
		    (cpu_has_feature(CPU_FTR_NOEXECUTE) ||

		     !(vma->vm_flags & (VM_READ | VM_WRITE))))

			goto bad_area;



#ifdef CONFIG_PPC_STD_MMU

		/*

		 * protfault should only happen due to us

		 * mapping a region readonly temporarily. PROT_NONE

		 * is also covered by the VMA check above.

		 */

		WARN_ON_ONCE(error_code & DSISR_PROTFAULT);

#endif /* CONFIG_PPC_STD_MMU */

	/* a write */

	} else if (is_write) {

		if (!(vma->vm_flags & VM_WRITE))
@@ -436,8 +427,40 @@ good_area: 
	} else {

		if (!(vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE)))

			goto bad_area;

		WARN_ON_ONCE(error_code & DSISR_PROTFAULT);

	}

#ifdef CONFIG_PPC_STD_MMU

	/*

	 * For hash translation mode, we should never get a

	 * PROTFAULT. Any update to pte to reduce access will result in us

	 * removing the hash page table entry, thus resulting in a DSISR_NOHPTE

	 * fault instead of DSISR_PROTFAULT.

	 *

	 * A pte update to relax the access will not result in a hash page table

	 * entry invalidate and hence can result in DSISR_PROTFAULT.

	 * ptep_set_access_flags() doesn't do a hpte flush. This is why we have

	 * the special !is_write in the below conditional.

	 *

	 * For platforms that doesn't supports coherent icache and do support

	 * per page noexec bit, we do setup things such that we do the

	 * sync between D/I cache via fault. But that is handled via low level

	 * hash fault code (hash_page_do_lazy_icache()) and we should not reach

	 * here in such case.

	 *

	 * For wrong access that can result in PROTFAULT, the above vma->vm_flags

	 * check should handle those and hence we should fall to the bad_area

	 * handling correctly.

	 *

	 * For embedded with per page exec support that doesn't support coherent

	 * icache we do get PROTFAULT and we handle that D/I cache sync in

	 * set_pte_at while taking the noexec/prot fault. Hence this is WARN_ON

	 * is conditional for server MMU.

	 *

	 * For radix, we can get prot fault for autonuma case, because radix

	 * page table will have them marked noaccess for user.

	 */

	if (!radix_enabled() && !is_write)

		WARN_ON_ONCE(error_code & DSISR_PROTFAULT);

#endif /* CONFIG_PPC_STD_MMU */



	/*

	 * If for any reason at all we couldn't handle the fault,

CRA Git | Maintained and supported by SUSTech CRA and CCSE