Commit 18007820 authored May 15, 2007 by Hugh Dickins Committed by Linus Torvalds May 16, 2007

slub: don't confuse ctor and dtor



kmem_cache_create() was swapping ctor and dtor in calling find_mergeable():
though it caused no bug, and probably never would, even if destructors are
retained; but fix it so as not to generate anxiety ;)

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1abd727e

mm/slub.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2522,7 +2522,7 @@ struct kmem_cache kmem_cache_create(const char name, size_t size,
		struct kmem_cache *s;

		down_write(&slub_lock);
		s = find_mergeable(size, align, flags, dtor, ctor);
		s = find_mergeable(size, align, flags, ctor, dtor);
		if (s) {
		s->refcount++;
		/*

Admin message