Unverified Commit 17fc2487 authored May 28, 2019 by Pierre-Louis Bossart Committed by Mark Brown May 29, 2019

ASoC: Intel: sof-rt5682: fix undefined references with Baytrail-only support



The sof-rt5682 machine driver supports both legacy Baytrail devices
and more recent ApolloLake/CometLake platforms. When only Baytrail is
selected, the compilation fails with the following errors:

ERROR: "hdac_hdmi_jack_port_init"
[sound/soc/intel/boards/snd-soc-sof_rt5682.ko] undefined!

ERROR: "hdac_hdmi_jack_init"
[sound/soc/intel/boards/snd-soc-sof_rt5682.ko] undefined!

Fix by selecting SND_SOC_HDAC_HDMI unconditionally. The code for HDMI
support is not reachable on Baytrail so this change has no functional
impact.

Fixes: f70abd75 ("ASoC: Intel: add sof-rt5682 machine driver")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent a5498811

sound/soc/intel/boards/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -402,7 +402,7 @@ config SND_SOC_INTEL_SOF_RT5682_MACH
		(SND_SOC_SOF_BAYTRAIL && X86_INTEL_LPSS)
		select SND_SOC_RT5682
		select SND_SOC_DMIC
		select SND_SOC_HDAC_HDMI if SND_SOC_SOF_HDA_COMMON
		select SND_SOC_HDAC_HDMI
		help
		This adds support for ASoC machine driver for SOF platforms
		with rt5682 codec.

Admin message