Commit 17f1bf38 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Andy Shevchenko
Browse files

platform/x86: ideapad-laptop: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ike Panhc <ike.pan@canonical.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 9ea18802

drivers/platform/x86/ideapad-laptop.c

+7 −29
Original line number Diff line number Diff line
@@ -330,34 +330,15 @@ static int debugfs_cfg_show(struct seq_file *s, void *data) 
}

DEFINE_SHOW_ATTRIBUTE(debugfs_cfg);



static int ideapad_debugfs_init(struct ideapad_private *priv)

static void ideapad_debugfs_init(struct ideapad_private *priv)

{

	struct dentry *node;

	struct dentry *dir;



	priv->debug = debugfs_create_dir("ideapad", NULL);

	if (priv->debug == NULL) {

		pr_err("failed to create debugfs directory");

		goto errout;

	}



	node = debugfs_create_file("cfg", S_IRUGO, priv->debug, priv,

				   &debugfs_cfg_fops);

	if (!node) {

		pr_err("failed to create cfg in debugfs");

		goto errout;

	}

	dir = debugfs_create_dir("ideapad", NULL);

	priv->debug = dir;



	node = debugfs_create_file("status", S_IRUGO, priv->debug, priv,

				   &debugfs_status_fops);

	if (!node) {

		pr_err("failed to create status in debugfs");

		goto errout;

	}



	return 0;



errout:

	return -ENOMEM;

	debugfs_create_file("cfg", S_IRUGO, dir, priv, &debugfs_cfg_fops);

	debugfs_create_file("status", S_IRUGO, dir, priv, &debugfs_status_fops);

}



static void ideapad_debugfs_exit(struct ideapad_private *priv)
@@ -1026,9 +1007,7 @@ static int ideapad_acpi_add(struct platform_device *pdev) 
	if (ret)

		return ret;



	ret = ideapad_debugfs_init(priv);

	if (ret)

		goto debugfs_failed;

	ideapad_debugfs_init(priv);



	ret = ideapad_input_init(priv);

	if (ret)
@@ -1085,7 +1064,6 @@ backlight_failed: 
	ideapad_input_exit(priv);

input_failed:

	ideapad_debugfs_exit(priv);

debugfs_failed:

	ideapad_sysfs_exit(priv);

	return ret;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE