Commit 17efbee8 authored Dec 14, 2015 by Andrey Smetanin Committed by Greg Kroah-Hartman Dec 14, 2015

drivers/hv: cleanup synic msrs if vmbus connect failed



Before vmbus_connect() synic is setup per vcpu - this means
hypervisor receives writes at synic msr's and probably allocate
hypervisor resources per synic setup.

If vmbus_connect() failed for some reason it's neccessary to cleanup
synic setup by call hv_synic_cleanup() at each vcpu to get a chance
to free allocated resources by hypervisor per synic.

This patch does appropriate cleanup in case of vmbus_connect() failure.

Signed-off-by: Andrey Smetanin <asmetanin@virtuozzo.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
CC: "K. Y. Srinivasan" <kys@microsoft.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b0035964

drivers/hv/vmbus_drv.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -867,7 +867,7 @@ static int vmbus_bus_init(int irq)
		on_each_cpu(hv_synic_init, NULL, 1);
		ret = vmbus_connect();
		if (ret)
		goto err_alloc;
		goto err_connect;

		if (vmbus_proto_version > VERSION_WIN7)
		cpu_hotplug_disable();
		@@ -885,6 +885,8 @@ static int vmbus_bus_init(int irq)

		return 0;

		err_connect:
		on_each_cpu(hv_synic_cleanup, NULL, 1);
		err_alloc:
		hv_synic_free();
		hv_remove_vmbus_irq();

Admin message