Unverified Commit 17d29ff9 authored Aug 27, 2019 by Amadeusz Sławiński Committed by Mark Brown Aug 27, 2019

ASoC: Intel: Skylake: Use correct function to access iomem space

For copying from __iomem, we should use __ioread32_copy.

reported by sparse:
sound/soc/intel/skylake/skl-debug.c:437:34: warning: incorrect type in argument 1 (different address spaces)
sound/soc/intel/skylake/skl-debug.c:437:34: expected void [noderef] <asn:2> *to
sound/soc/intel/skylake/skl-debug.c:437:34: got unsigned char *
sound/soc/intel/skylake/skl-debug.c:437:51: warning: incorrect type in argument 2 (different address spaces)
sound/soc/intel/skylake/skl-debug.c:437:51: expected void const *from
sound/soc/intel/skylake/skl-debug.c:437:51: got void [noderef] <asn:2> *[assigned] fw_reg_addr

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>
Link: https://lore.kernel.org/r/20190827141712.21015-2-amadeuszx.slawinski@linux.intel.com

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

parent 0ce6a624

sound/soc/intel/skylake/skl-debug.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -188,7 +188,7 @@ static ssize_t fw_softreg_read(struct file file, char __user user_buf,
		memset(d->fw_read_buff, 0, FW_REG_BUF);

		if (w0_stat_sz > 0)
		__iowrite32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2);
		__ioread32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2);

		for (offset = 0; offset < FW_REG_SIZE; offset += 16) {
		ret += snprintf(tmp + ret, FW_REG_BUF - ret, "%#.4x: ", offset);

Admin message