Commit 17c12bcd authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: when replaying bmap operations, don't let unlinked inodes get reaped 



Log recovery will iget an inode to replay BUI items and iput the inode
when it's done.  Unfortunately, if the inode was unlinked, the iput
will see that i_nlink == 0 and decide to truncate & free the inode,
which prevents us from replaying subsequent BUIs.  We can't skip the
BUIs because we have to replay all the redo items to ensure that
atomic operations complete.

Since unlinked inode recovery will reap the inode anyway, we can
safely introduce a new inode flag to indicate that an inode is in this
'unlinked recovery' state and should not be auto-reaped in the
drop_inode path.

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 9f3afb57

fs/xfs/xfs_bmap_item.c

+2 −0
Original line number Diff line number Diff line
@@ -456,6 +456,8 @@ xfs_bui_recover( 
	if (error)

		goto err_inode;



	if (VFS_I(ip)->i_nlink == 0)

		xfs_iflags_set(ip, XFS_IRECOVERY);

	xfs_defer_init(&dfops, &firstfsb);



	/* Process deferred bmap item. */

fs/xfs/xfs_inode.c

+1 −0
Original line number Diff line number Diff line
@@ -1850,6 +1850,7 @@ xfs_inactive( 
	}



	mp = ip->i_mount;

	ASSERT(!xfs_iflags_test(ip, XFS_IRECOVERY));



	/* If this is a read-only mount, don't do this (would generate I/O) */

	if (mp->m_flags & XFS_MOUNT_RDONLY)

fs/xfs/xfs_inode.h

+6 −0
Original line number Diff line number Diff line
@@ -222,6 +222,12 @@ static inline bool xfs_is_reflink_inode(struct xfs_inode *ip) 
#define XFS_IPINNED		(1 << __XFS_IPINNED_BIT)

#define XFS_IDONTCACHE		(1 << 9) /* don't cache the inode long term */

#define XFS_IEOFBLOCKS		(1 << 10)/* has the preallocblocks tag set */

/*

 * If this unlinked inode is in the middle of recovery, don't let drop_inode

 * truncate and free the inode.  This can happen if we iget the inode during

 * log recovery to replay a bmap operation on the inode.

 */

#define XFS_IRECOVERY		(1 << 11)



/*

 * Per-lifetime flags need to be reset when re-using a reclaimable inode during

fs/xfs/xfs_log_recover.c

+1 −0
Original line number Diff line number Diff line
@@ -4969,6 +4969,7 @@ xlog_recover_process_one_iunlink( 
	if (error)

		goto fail_iput;



	xfs_iflags_clear(ip, XFS_IRECOVERY);

	ASSERT(VFS_I(ip)->i_nlink == 0);

	ASSERT(VFS_I(ip)->i_mode != 0);

fs/xfs/xfs_mount.c

+9 −0
Original line number Diff line number Diff line
@@ -924,6 +924,15 @@ xfs_mountfs( 
		}

	}



	/*

	 * During the second phase of log recovery, we need iget and

	 * iput to behave like they do for an active filesystem.

	 * xfs_fs_drop_inode needs to be able to prevent the deletion

	 * of inodes before we're done replaying log items on those

	 * inodes.

	 */

	mp->m_super->s_flags |= MS_ACTIVE;



	/*

	 * Finish recovering the file system.  This part needed to be delayed

	 * until after the root and real-time bitmap inodes were consistently

CRA Git | Maintained and supported by SUSTech CRA and CCSE