Commit 17bdcf94 authored Oct 11, 2010 by Linus Walleij Committed by Ingo Molnar Oct 18, 2010

sched: Drop all load weight manipulation for RT tasks



Load weights are for the CFS, they do not belong in the RT task. This makes all
RT scheduling classes leave the CFS weights alone.

This fixes a real bug as well: I noticed the following phonomena: a process
elevated to SCHED_RR forks with SCHED_RESET_ON_FORK set, and the child is
indeed SCHED_OTHER, and the niceval is indeed reset to 0. However the weight
inserted by set_load_weight() remains at 0, giving the task insignificat
priority.

With this fix, the weight is reset to what the task had before being elevated
to SCHED_RR/SCHED_FIFO.

Cc: Lennart Poettering <lennart@poettering.net>
Cc: stable@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1286807811-10568-1-git-send-email-linus.walleij@stericsson.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 34f971f6

kernel/sched.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1855,12 +1855,6 @@ static void dec_nr_running(struct rq *rq)

		static void set_load_weight(struct task_struct *p)
		{
		if (task_has_rt_policy(p)) {
		p->se.load.weight = 0;
		p->se.load.inv_weight = WMULT_CONST;
		return;
		}

		/*
		* SCHED_IDLE tasks get minimal weight:
		*/

Admin message