Commit 17bc6d07 authored Jun 26, 2019 by Tony Nguyen Committed by Jeff Kirsher Jul 31, 2019

ice: Move vector base setup to PF VSI



When interrupt tracking was refactored, during rebuild, the call to
ice_vsi_setup_vector_base() was inadvertently removed from the PF VSI
instead of being removed from the VF VSI. During reset, the failure to
properly setup the vector base generates a call trace. Correct this so
that resets/rebuilds properly complete.

Fixes: cbe66bfe ("ice: Refactor interrupt tracking")
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 36517fd3

drivers/net/ethernet/intel/ice/ice_lib.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2978,6 +2978,10 @@ int ice_vsi_rebuild(struct ice_vsi *vsi)
		if (ret)
		goto err_rings;

		ret = ice_vsi_setup_vector_base(vsi);
		if (ret)
		goto err_vectors;

		ret = ice_vsi_set_q_vectors_reg_idx(vsi);
		if (ret)
		goto err_vectors;
		@@ -2999,10 +3003,6 @@ int ice_vsi_rebuild(struct ice_vsi *vsi)
		if (ret)
		goto err_rings;

		ret = ice_vsi_setup_vector_base(vsi);
		if (ret)
		goto err_vectors;

		ret = ice_vsi_set_q_vectors_reg_idx(vsi);
		if (ret)
		goto err_vectors;

Admin message