staging: rtl8723bs: remove set but not used variable 'pmlmeinfo', 'pHalData' (17b937a9) · Commits · 戴 / test

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: In function ConstructBtNullFunctionData: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:2099:24: warning: variable pmlmeinfo set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: In function SetFwRsvdPagePkt_BTCoex: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:2154:24: warning: variable pmlmeinfo set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c: In function SetFwRsvdPagePkt_BTCoex: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:2149:23: warning: variable pHalData set but not used [-Wunused-but-set-variable] They are introduced by commit ("staging: Add rtl8723bs sdio wifi driver"), but never used, so remove them. Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

zhengbin <zhengbin13@huawei.com> Link: https://lore.kernel.org/r/1574063156-68155-4-git-send-email-zhengbin13@huawei.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -2071,8 +2071,6 @@ static void ConstructBtNullFunctionData(
		struct ieee80211_hdr *pwlanhdr;
		__le16 *fctrl;
		u32 pktlen;
		struct mlme_ext_priv *pmlmeext;
		struct mlme_ext_info *pmlmeinfo;
		u8 bssid[ETH_ALEN];


		@@ -2080,8 +2078,6 @@ static void ConstructBtNullFunctionData(
		FUNC_ADPT_ARG(padapter), bQoS, bEosp, bForcePowerSave);

		pwlanhdr = (struct ieee80211_hdr *)pframe;
		pmlmeext = &padapter->mlmeextpriv;
		pmlmeinfo = &pmlmeext->mlmext_info;

		if (!StaAddr) {
		memcpy(bssid, myid(&padapter->eeprompriv), ETH_ALEN);
		@@ -2122,12 +2118,9 @@ static void ConstructBtNullFunctionData(

		static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)
		{
		struct hal_com_data *pHalData;
		struct xmit_frame *pcmdframe;
		struct pkt_attrib *pattrib;
		struct xmit_priv *pxmitpriv;
		struct mlme_ext_priv *pmlmeext;
		struct mlme_ext_info *pmlmeinfo;
		u32 BeaconLength = 0;
		u32 BTQosNullLength = 0;
		u8 *ReservedPagePacket;
		@@ -2140,10 +2133,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)

		/* DBG_8192C("+" FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(padapter)); */

		pHalData = GET_HAL_DATA(padapter);
		pxmitpriv = &padapter->xmitpriv;
		pmlmeext = &padapter->mlmeextpriv;
		pmlmeinfo = &pmlmeext->mlmext_info;
		TxDescLen = TXDESC_SIZE;
		TxDescOffset = TXDESC_OFFSET;
		PageSize = PAGE_SIZE_TX_8723B;

Admin message