Commit 17a8f868 authored by Viresh Kumar's avatar Viresh Kumar
Browse files

opp: Return genpd virtual devices from dev_pm_opp_attach_genpd() 



The cpufreq drivers don't need to do runtime PM operations on the
virtual devices returned by dev_pm_domain_attach_by_name() and so the
virtual devices weren't shared with the callers of
dev_pm_opp_attach_genpd() earlier.

But the IO device drivers would want to do that. This patch updates the
prototype of dev_pm_opp_attach_genpd() to accept another argument to
return the pointer to the array of genpd virtual devices.

Reported-by: default avatarRajendra Nayak <rnayak@codeaurora.org>
Tested-by: default avatarRajendra Nayak <rnayak@codeaurora.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent baea35e4

drivers/opp/core.c

+5 −1
Original line number Diff line number Diff line
@@ -1771,6 +1771,7 @@ static void _opp_detach_genpd(struct opp_table *opp_table) 
 * dev_pm_opp_attach_genpd - Attach genpd(s) for the device and save virtual device pointer

 * @dev: Consumer device for which the genpd is getting attached.

 * @names: Null terminated array of pointers containing names of genpd to attach.

 * @virt_devs: Pointer to return the array of virtual devices.

 *

 * Multiple generic power domains for a device are supported with the help of

 * virtual genpd devices, which are created for each consumer device - genpd
@@ -1788,7 +1789,8 @@ static void _opp_detach_genpd(struct opp_table *opp_table) 
 * The order of entries in the names array must match the order in which

 * "required-opps" are added in DT.

 */

struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names)

struct opp_table *dev_pm_opp_attach_genpd(struct device *dev,

		const char **names, struct device ***virt_devs)

{

	struct opp_table *opp_table;

	struct device *virt_dev;
@@ -1842,6 +1844,8 @@ struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names 
		name++;

	}



	if (virt_devs)

		*virt_devs = opp_table->genpd_virt_devs;

	mutex_unlock(&opp_table->genpd_virt_dev_lock);



	return opp_table;

include/linux/pm_opp.h

+2 −2
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ struct opp_table *dev_pm_opp_set_clkname(struct device *dev, const char * name); 
void dev_pm_opp_put_clkname(struct opp_table *opp_table);

struct opp_table *dev_pm_opp_register_set_opp_helper(struct device *dev, int (*set_opp)(struct dev_pm_set_opp_data *data));

void dev_pm_opp_unregister_set_opp_helper(struct opp_table *opp_table);

struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names);

struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names, struct device ***virt_devs);

void dev_pm_opp_detach_genpd(struct opp_table *opp_table);

int dev_pm_opp_xlate_performance_state(struct opp_table *src_table, struct opp_table *dst_table, unsigned int pstate);

int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq);
@@ -292,7 +292,7 @@ static inline struct opp_table *dev_pm_opp_set_clkname(struct device *dev, const 


static inline void dev_pm_opp_put_clkname(struct opp_table *opp_table) {}



static inline struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names)

static inline struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names, struct device ***virt_devs)

{

	return ERR_PTR(-ENOTSUPP);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE