Commit 178f67b1 authored Jun 05, 2020 by Dan Carpenter Committed by David S. Miller Jun 05, 2020

ethtool: linkinfo: remove an unnecessary NULL check



This code generates a Smatch warning:

    net/ethtool/linkinfo.c:143 ethnl_set_linkinfo()
    warn: variable dereferenced before check 'info' (see line 119)

Fortunately, the "info" pointer is never NULL so the check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7d877c35

net/ethtool/linkinfo.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -140,7 +140,6 @@ int ethnl_set_linkinfo(struct sk_buff skb, struct genl_info info)

		ret = __ethtool_get_link_ksettings(dev, &ksettings);
		if (ret < 0) {
		if (info)
		GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
		goto out_ops;
		}

Admin message