Commit 177c8d1c authored Feb 19, 2017 by Christophe Jaillet Committed by David S. Miller Feb 20, 2017

net: mvpp2: Fix a memory leak in error handling path



if 'devm_kzalloc()' fails, we should release resources allocated so far,
just as done a few lines below.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3608b13c

drivers/net/ethernet/marvell/mvpp2.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -5971,8 +5971,10 @@ static int mvpp2_port_init(struct mvpp2_port *port)
		struct mvpp2_tx_queue *txq;

		txq = devm_kzalloc(dev, sizeof(*txq), GFP_KERNEL);
		if (!txq)
		return -ENOMEM;
		if (!txq) {
		err = -ENOMEM;
		goto err_free_percpu;
		}

		txq->pcpu = alloc_percpu(struct mvpp2_txq_pcpu);
		if (!txq->pcpu) {

Admin message