Commit 176306f5 authored May 24, 2010 by Neil Brown Committed by Al Viro May 27, 2010

VFS: fix recent breakage of FS_REVAL_DOT



Commit 1f36f774 broke FS_REVAL_DOT semantics.

In particular, before this patch, the command
   ls -l
in an NFS mounted directory would always check if the directory on the server
had changed and if so would flush and refill the pagecache for the dir.
After this patch, the same "ls -l" will repeatedly return stale date until
the cached attributes for the directory time out.

The following patch fixes this by ensuring the d_revalidate is called by
do_last when "." is being looked-up.
link_path_walk has already called d_revalidate, but in that case LOOKUP_OPEN
is not set so nfs_lookup_verify_inode chooses not to do any validation.

The following patch restores the original behaviour.

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 1eb2cbb6

fs/namei.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1621,6 +1621,7 @@ static struct file do_last(struct nameidata nd, struct path *path,
		case LAST_DOTDOT:
		follow_dotdot(nd);
		dir = nd->path.dentry;
		case LAST_DOT:
		if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) {
		if (!dir->d_op->d_revalidate(dir, nd)) {
		error = -ESTALE;
		@@ -1628,7 +1629,6 @@ static struct file do_last(struct nameidata nd, struct path *path,
		}
		}
		/* fallthrough */
		case LAST_DOT:
		case LAST_ROOT:
		if (open_flag & O_CREAT)
		goto exit;

Admin message