Commit 1748ce80 authored Nov 08, 2019 by Jacob Keller Committed by Jeff Kirsher Nov 22, 2019

ice: remove pointless NULL check of port_info



The code in ice_sched_cleanup_all checks whether the port info is NULL
prior to calling ice_sched_clear_port. However, ice_sched_clear_port
already checks whether port info is non-NULL.

More importantly, it also checks whether the port structure has been
initialized by checking its port_state field as well.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 87324e74

drivers/net/ethernet/intel/ice/ice_sched.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -798,7 +798,6 @@ void ice_sched_cleanup_all(struct ice_hw *hw)
		hw->layer_info = NULL;
		}

		if (hw->port_info)
		ice_sched_clear_port(hw->port_info);

		hw->num_tx_sched_layers = 0;

Admin message