Commit 1741acea authored Dec 15, 2014 by Lv Zheng Committed by Rafael J. Wysocki Dec 15, 2014

ACPI / EC: Fix unexpected ec_remove_handlers() invocations



The ec_remove_handlers() is invoked without checking
EC_FLAGS_HANDLERS_INSTALLED, this patch enhances this check to avoid issues
that acpi_disable_gpe() is invoked unexpectedly to reduce the GPE runtime
count. This may happen when the EC handler installation failed on some
platforms.

Reported-by: Venkat Raghavulu <venkat.raghavulu@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent b2776bf7

drivers/acpi/ec.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -844,6 +844,8 @@ static int ec_install_handlers(struct acpi_ec *ec)

		static void ec_remove_handlers(struct acpi_ec *ec)
		{
		if (!test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
		return;
		acpi_disable_gpe(NULL, ec->gpe);
		if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
		ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))

Admin message