Commit 173b8f49 authored by Chuck Lever's avatar Chuck Lever Committed by Anna Schumaker
Browse files

xprtrdma: Demote "connect" log messages 



Some have complained about the log messages generated when xprtrdma
opens or closes a connection to a server. When an NFS mount is
mostly idle these can appear every few minutes as the client idles
out the connection and reconnects.

Connection and disconnection is a normal part of operation, and not
exceptional, so change these to dprintk's for now. At some point
all of these will be converted to tracepoints, but that's for
another day.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 838edb94

net/sunrpc/xprtrdma/verbs.c

+8 −36
Original line number Diff line number Diff line
@@ -243,8 +243,6 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event) 
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)

	struct sockaddr *sap = (struct sockaddr *)&ep->rep_remote_addr;

#endif

	struct ib_qp_attr *attr = &ia->ri_qp_attr;

	struct ib_qp_init_attr *iattr = &ia->ri_qp_init_attr;

	int connstate = 0;



	switch (event->event) {
@@ -267,7 +265,8 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event) 
		break;

	case RDMA_CM_EVENT_DEVICE_REMOVAL:

#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)

		pr_info("rpcrdma: removing device for %pIS:%u\n",

		pr_info("rpcrdma: removing device %s for %pIS:%u\n",

			ia->ri_device->name,

			sap, rpc_get_port(sap));

#endif

		set_bit(RPCRDMA_IAF_REMOVING, &ia->ri_flags);
@@ -282,13 +281,6 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event) 
		return 1;

	case RDMA_CM_EVENT_ESTABLISHED:

		connstate = 1;

		ib_query_qp(ia->ri_id->qp, attr,

			    IB_QP_MAX_QP_RD_ATOMIC | IB_QP_MAX_DEST_RD_ATOMIC,

			    iattr);

		dprintk("RPC:       %s: %d responder resources"

			" (%d initiator)\n",

			__func__, attr->max_dest_rd_atomic,

			attr->max_rd_atomic);

		rpcrdma_update_connect_private(xprt, &event->param.conn);

		goto connected;

	case RDMA_CM_EVENT_CONNECT_ERROR:
@@ -298,11 +290,9 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event) 
		connstate = -ENETDOWN;

		goto connected;

	case RDMA_CM_EVENT_REJECTED:

#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)

		pr_info("rpcrdma: connection to %pIS:%u on %s rejected: %s\n",

			sap, rpc_get_port(sap), ia->ri_device->name,

		dprintk("rpcrdma: connection to %pIS:%u rejected: %s\n",

			sap, rpc_get_port(sap),

			rdma_reject_msg(id, event->status));

#endif

		connstate = -ECONNREFUSED;

		if (event->status == IB_CM_REJ_STALE_CONN)

			connstate = -EAGAIN;
@@ -310,37 +300,19 @@ rpcrdma_conn_upcall(struct rdma_cm_id *id, struct rdma_cm_event *event) 
	case RDMA_CM_EVENT_DISCONNECTED:

		connstate = -ECONNABORTED;

connected:

		dprintk("RPC:       %s: %sconnected\n",

					__func__, connstate > 0 ? "" : "dis");

		atomic_set(&xprt->rx_buf.rb_credits, 1);

		ep->rep_connected = connstate;

		rpcrdma_conn_func(ep);

		wake_up_all(&ep->rep_connect_wait);

		/*FALLTHROUGH*/

	default:

		dprintk("RPC:       %s: %pIS:%u (ep 0x%p): %s\n",

			__func__, sap, rpc_get_port(sap), ep,

			rdma_event_msg(event->event));

		dprintk("RPC:       %s: %pIS:%u on %s/%s (ep 0x%p): %s\n",

			__func__, sap, rpc_get_port(sap),

			ia->ri_device->name, ia->ri_ops->ro_displayname,

			ep, rdma_event_msg(event->event));

		break;

	}



#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)

	if (connstate == 1) {

		int ird = attr->max_dest_rd_atomic;

		int tird = ep->rep_remote_cma.responder_resources;



		pr_info("rpcrdma: connection to %pIS:%u on %s, memreg '%s', %d credits, %d responders%s\n",

			sap, rpc_get_port(sap),

			ia->ri_device->name,

			ia->ri_ops->ro_displayname,

			xprt->rx_buf.rb_max_requests,

			ird, ird < 4 && ird < tird / 2 ? " (low!)" : "");

	} else if (connstate < 0) {

		pr_info("rpcrdma: connection to %pIS:%u closed (%d)\n",

			sap, rpc_get_port(sap), connstate);

	}

#endif



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE