Commit 1724b95b authored Aug 11, 2020 by Jiang Biao Committed by Peter Zijlstra Aug 26, 2020

sched/fair: Simplify the work when reweighting entity



The code in reweight_entity() can be simplified.

For a sched entity on the rq, the entity accounting can be replaced by
cfs_rq instantaneous load updates currently called from within the
entity accounting.

Even though an entity on the rq can't represent a task in
reweight_entity() (a task is always dequeued before calling this
function) and so the numa task accounting and the rq->cfs_tasks list
management of the entity accounting are never called, the redundant
cfs_rq->nr_running decrement/increment will be avoided.

Signed-off-by: Jiang Biao <benbjiang@tencent.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/20200811113209.34057-1-benbjiang@tencent.com

parent da0777d3

kernel/sched/fair.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3084,7 +3084,7 @@ static void reweight_entity(struct cfs_rq cfs_rq, struct sched_entity se,
		/* commit outstanding execution time */
		if (cfs_rq->curr == se)
		update_curr(cfs_rq);
		account_entity_dequeue(cfs_rq, se);
		update_load_sub(&cfs_rq->load, se->load.weight);
		}
		dequeue_load_avg(cfs_rq, se);

		@@ -3100,7 +3100,7 @@ static void reweight_entity(struct cfs_rq cfs_rq, struct sched_entity se,

		enqueue_load_avg(cfs_rq, se);
		if (se->on_rq)
		account_entity_enqueue(cfs_rq, se);
		update_load_add(&cfs_rq->load, se->load.weight);

		}

Admin message