Commit 171a7000 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by David S. Miller
Browse files

nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified 



Two functions accept pointer to struct s3fwrn5_fw_info but do not
modify the contents.  Make them const so the code is a little bit safer.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4aa62c62

drivers/nfc/s3fwrn5/firmware.c

+2 −2
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static int s3fwrn5_fw_get_base_addr( 
}



static inline bool

s3fwrn5_fw_is_custom(struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)

s3fwrn5_fw_is_custom(const struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)

{

	return !!bootinfo->hw_version[2];

}
@@ -399,7 +399,7 @@ err: 
	return ret;

}



bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version)

bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version)

{

	struct s3fwrn5_fw_version *new = (void *) &fw_info->fw.version;

	struct s3fwrn5_fw_version *old = (void *) &version;

drivers/nfc/s3fwrn5/firmware.h

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ struct s3fwrn5_fw_info { 


void s3fwrn5_fw_init(struct s3fwrn5_fw_info *fw_info, const char *fw_name);

int s3fwrn5_fw_setup(struct s3fwrn5_fw_info *fw_info);

bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version);

bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version);

int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info);

void s3fwrn5_fw_cleanup(struct s3fwrn5_fw_info *fw_info);

CRA Git | Maintained and supported by SUSTech CRA and CCSE