Commit 171012f5 authored Mar 16, 2017 by Dmitry Vyukov Committed by Linus Torvalds Mar 16, 2017

mm: don't warn when vmalloc() fails due to a fatal signal

When vmalloc() fails it prints a very lengthy message with all the
details about memory consumption assuming that it happened due to OOM.

However, vmalloc() can also fail due to fatal signal pending.  In such
case the message is quite confusing because it suggests that it is OOM
but the numbers suggest otherwise.  The messages can also pollute
console considerably.

Don't warn when vmalloc() fails due to fatal signal pending.

Link: http://lkml.kernel.org/r/20170313114425.72724-1-dvyukov@google.com


Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d0f33ac9

mm/vmalloc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1683,7 +1683,7 @@ static void __vmalloc_area_node(struct vm_struct area, gfp_t gfp_mask,

		if (fatal_signal_pending(current)) {
		area->nr_pages = i;
		goto fail;
		goto fail_no_warn;
		}

		if (node == NUMA_NO_NODE)
		@@ -1709,6 +1709,7 @@ fail:
		warn_alloc(gfp_mask, NULL,
		"vmalloc: allocation failure, allocated %ld of %ld bytes",
		(area->nr_pages*PAGE_SIZE), area->size);
		fail_no_warn:
		vfree(area->addr);
		return NULL;
		}

Admin message