Commit 1708dd54 authored by Eli Cohen's avatar Eli Cohen Committed by Saeed Mahameed
Browse files

net/mlx5: Eswitch, avoid redundant mask 



misc_params.source_port is a 16 bit field already so no need for
redundant masking against 0xffff. Also change local variables type to
u16.

Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Reviewed-by: default avatarRoi Dayan <roid@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent ffec9702

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c

+2 −2
Original line number Diff line number Diff line
@@ -181,7 +181,7 @@ mlx5_eswitch_termtbl_actions_move(struct mlx5_flow_act *src, 
static bool mlx5_eswitch_offload_is_uplink_port(const struct mlx5_eswitch *esw,

						const struct mlx5_flow_spec *spec)

{

	u32 port_mask, port_value;

	u16 port_mask, port_value;



	if (MLX5_CAP_ESW_FLOWTABLE(esw->dev, flow_source))

		return spec->flow_context.flow_source ==
@@ -191,7 +191,7 @@ static bool mlx5_eswitch_offload_is_uplink_port(const struct mlx5_eswitch *esw, 
			     misc_parameters.source_port);

	port_value = MLX5_GET(fte_match_param, spec->match_value,

			      misc_parameters.source_port);

	return (port_mask & port_value & 0xffff) == MLX5_VPORT_UPLINK;

	return (port_mask & port_value) == MLX5_VPORT_UPLINK;

}



bool

CRA Git | Maintained and supported by SUSTech CRA and CCSE