Commit 16d91548 authored Jun 02, 2020 by Linus Torvalds

xfs-linux

Pull xfs updates from Darrick Wong:
 "Most of the changes this cycle are refactoring of existing code in
  preparation for things landing in the future.

  We also fixed various problems and deficiencies in the quota
  implementation, and (I hope) the last of the stale read vectors by
  forcing write allocations to go through the unwritten state until the
  write completes.

  Summary:

   - Various cleanups to remove dead code, unnecessary conditionals,
     asserts, etc.

   - Fix a linker warning caused by xfs stuffing '-g' into CFLAGS
     redundantly.

   - Tighten up our dmesg logging to ensure that everything is prefixed
     with 'XFS' for easier grepping.

   - Kill a bunch of typedefs.

   - Refactor the deferred ops code to reduce indirect function calls.

   - Increase type-safety with the deferred ops code.

   - Make the DAX mount options a tri-state.

   - Fix some error handling problems in the inode flush code and clean
     up other inode flush warts.

   - Refactor log recovery so that each log item recovery functions now
     live with the other log item processing code.

   - Fix some SPDX forms.

   - Fix quota counter corruption if the fs crashes after running
     quotacheck but before any dquots get logged.

   - Don't fail metadata verification on zero-entry attr leaf blocks,
     since they're just part of the disk format now due to a historic
     lack of log atomicity.

   - Don't allow SWAPEXT between files with different [ugp]id when
     quotas are enabled.

   - Refactor inode fork reading and verification to run directly from
     the inode-from-disk function. This means that we now actually
     guarantee that _iget'ted inodes are totally verified and ready to
     go.

   - Move the incore inode fork format and extent counts to the ifork
     structure.

   - Scalability improvements by reducing cacheline pingponging in
     struct xfs_mount.

   - More scalability improvements by removing m_active_trans from the
     hot path.

   - Fix inode counter update sanity checking to run /only/ on debug
     kernels.

   - Fix longstanding inconsistency in what error code we return when a
     program hits project quota limits (ENOSPC).

   - Fix group quota returning the wrong error code when a program hits
     group quota limits.

   - Fix per-type quota limits and grace periods for group and project
     quotas so that they actually work.

   - Allow extension of individual grace periods.

   - Refactor the non-reclaim inode radix tree walking code to remove a
     bunch of stupid little functions and straighten out the
     inconsistent naming schemes.

   - Fix a bug in speculative preallocation where we measured a new
     allocation based on the last extent mapping in the file instead of
     looking farther for the last contiguous space allocation.

   - Force delalloc writes to unwritten extents. This closes a stale
     disk contents exposure vector if the system goes down before the
     write completes.

   - More lockdep whackamole"

* tag 'xfs-5.8-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: (129 commits)
  xfs: more lockdep whackamole with kmem_alloc*
  xfs: force writes to delalloc regions to unwritten
  xfs: refactor xfs_iomap_prealloc_size
  xfs: measure all contiguous previous extents for prealloc size
  xfs: don't fail unwritten extent conversion on writeback due to edquot
  xfs: rearrange xfs_inode_walk_ag parameters
  xfs: straighten out all the naming around incore inode tree walks
  xfs: move xfs_inode_ag_iterator to be closer to the perag walking code
  xfs: use bool for done in xfs_inode_ag_walk
  xfs: fix inode ag walk predicate function return values
  xfs: refactor eofb matching into a single helper
  xfs: remove __xfs_icache_free_eofblocks
  xfs: remove flags argument from xfs_inode_ag_walk
  xfs: remove xfs_inode_ag_iterator_flags
  xfs: remove unused xfs_inode_ag_iterator function
  xfs: replace open-coded XFS_ICI_NO_TAG
  xfs: move eofblocks conversion function to xfs_ioctl.c
  xfs: allow individual quota grace period extension
  xfs: per-type quota timers and warn limits
  xfs: switch xfs_get_defquota to take explicit type
  ...

parents d9afbb35 6dcde60e

Documentation/filesystems/xfs-self-describing-metadata.rst

+5 −5

Original line number	Diff line number	Diff line
		@@ -340,11 +340,11 @@ buffer.

		The structure of the verifiers and the identifiers checks is very similar to the
		buffer code described above. The only difference is where they are called. For
		example, inode read verification is done in xfs_iread() when the inode is first
		read out of the buffer and the struct xfs_inode is instantiated. The inode is
		already extensively verified during writeback in xfs_iflush_int, so the only
		addition here is to add the LSN and CRC to the inode as it is copied back into
		the buffer.
		example, inode read verification is done in xfs_inode_from_disk() when the inode
		is first read out of the buffer and the struct xfs_inode is instantiated. The
		inode is already extensively verified during writeback in xfs_iflush_int, so the
		only addition here is to add the LSN and CRC to the inode as it is copied back
		into the buffer.

		XXX: inode unlinked list modification doesn't recalculate the inode CRC! None of
		the unlinked list modifications check or update CRCs, neither during unlink nor

fs/xfs/Makefile

+3 −2

Original line number	Diff line number	Diff line
		@@ -7,8 +7,6 @@
		ccflags-y += -I $(srctree)/$(src) # needed for trace events
		ccflags-y += -I $(srctree)/$(src)/libxfs

		ccflags-$(CONFIG_XFS_DEBUG) += -g

		obj-$(CONFIG_XFS_FS) += xfs.o

		# this one should be compiled first, as the tracing macros can easily blow up
		@@ -101,9 +99,12 @@ xfs-y += xfs_log.o \
		xfs_log_cil.o \
		xfs_bmap_item.o \
		xfs_buf_item.o \
		xfs_buf_item_recover.o \
		xfs_dquot_item_recover.o \
		xfs_extfree_item.o \
		xfs_icreate_item.o \
		xfs_inode_item.o \
		xfs_inode_item_recover.o \
		xfs_refcount_item.o \
		xfs_rmap_item.o \
		xfs_log_recover.o \

fs/xfs/kmem.h

+6 −2

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0
		/* SPDX-License-Identifier: GPL-2.0 */
		/*
		* Copyright (c) 2000-2005 Silicon Graphics, Inc.
		* All Rights Reserved.
		@@ -19,6 +19,7 @@ typedef unsigned __bitwise xfs_km_flags_t;
		#define KM_NOFS ((__force xfs_km_flags_t)0x0004u)
		#define KM_MAYFAIL ((__force xfs_km_flags_t)0x0008u)
		#define KM_ZERO ((__force xfs_km_flags_t)0x0010u)
		#define KM_NOLOCKDEP ((__force xfs_km_flags_t)0x0020u)

		/*
		* We use a special process flag to avoid recursive callbacks into
		@@ -30,7 +31,7 @@ kmem_flags_convert(xfs_km_flags_t flags)
		{
		gfp_t lflags;

		BUG_ON(flags & ~(KM_NOFS\|KM_MAYFAIL\|KM_ZERO));
		BUG_ON(flags & ~(KM_NOFS \| KM_MAYFAIL \| KM_ZERO \| KM_NOLOCKDEP));

		lflags = GFP_KERNEL \| __GFP_NOWARN;
		if (flags & KM_NOFS)
		@@ -49,6 +50,9 @@ kmem_flags_convert(xfs_km_flags_t flags)
		if (flags & KM_ZERO)
		lflags \|= __GFP_ZERO;

		if (flags & KM_NOLOCKDEP)
		lflags \|= __GFP_NOLOCKDEP;

		return lflags;
		}

fs/xfs/libxfs/xfs_ag_resv.h

+1 −1

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0+
		/* SPDX-License-Identifier: GPL-2.0+ */
		/*
		* Copyright (C) 2016 Oracle. All Rights Reserved.
		* Author: Darrick J. Wong <darrick.wong@oracle.com>

fs/xfs/libxfs/xfs_alloc.h

+1 −1

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0
		/* SPDX-License-Identifier: GPL-2.0 */
		/*
		* Copyright (c) 2000-2002,2005 Silicon Graphics, Inc.
		* All Rights Reserved.

Admin message