Commit 16cb3653 authored Oct 08, 2020 by Pujin Shi Committed by Jakub Kicinski Oct 10, 2020

net: smc: fix missing brace warning for old compilers



For older versions of gcc, the array = {0}; will cause warnings:

net/smc/smc_llc.c: In function 'smc_llc_add_link_local':
net/smc/smc_llc.c:1212:9: warning: missing braces around initializer [-Wmissing-braces]
  struct smc_llc_msg_add_link add_llc = {0};
         ^
net/smc/smc_llc.c:1212:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces]
net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local':
net/smc/smc_llc.c:1245:9: warning: missing braces around initializer [-Wmissing-braces]
  struct smc_llc_msg_del_link del_llc = {0};
         ^
net/smc/smc_llc.c:1245:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces]

2 warnings generated

Fixes: 4dadd151 ("net/smc: enqueue local LLC messages")
Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 7e94e46c

net/smc/smc_llc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1209,7 +1209,7 @@ static void smc_llc_process_srv_add_link(struct smc_link_group *lgr)
		/* enqueue a local add_link req to trigger a new add_link flow */
		void smc_llc_add_link_local(struct smc_link *link)
		{
		struct smc_llc_msg_add_link add_llc = {0};
		struct smc_llc_msg_add_link add_llc = {};

		add_llc.hd.length = sizeof(add_llc);
		add_llc.hd.common.type = SMC_LLC_ADD_LINK;
		@@ -1242,7 +1242,7 @@ out:
		*/
		void smc_llc_srv_delete_link_local(struct smc_link *link, u8 del_link_id)
		{
		struct smc_llc_msg_del_link del_llc = {0};
		struct smc_llc_msg_del_link del_llc = {};

		del_llc.hd.length = sizeof(del_llc);
		del_llc.hd.common.type = SMC_LLC_DELETE_LINK;

Admin message