Commit 16caf5b6 authored Oct 23, 2014 by Jan Kara Committed by Trond Myklebust Nov 12, 2014

nfs: Fix use of uninitialized variable in nfs_getattr()



Variable 'err' needn't be initialized when nfs_getattr() uses it to
check whether it should call generic_fillattr() or not. That can result
in spurious error returns. Initialize 'err' properly.

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent b283f944

fs/nfs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -626,7 +626,7 @@ int nfs_getattr(struct vfsmount mnt, struct dentry dentry, struct kstat *stat)
		{
		struct inode *inode = dentry->d_inode;
		int need_atime = NFS_I(inode)->cache_validity & NFS_INO_INVALID_ATIME;
		int err;
		int err = 0;

		trace_nfs_getattr_enter(inode);
		/* Flush out writes to the server in order to update c/mtime. */

Admin message