Commit 16b7f3c8 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: avoid warning about uninitialized_var() 



WARNING: function definition argument 'flags' should also have an identifier name
#26: FILE: drivers/tty/serial/sh-sci.c:1348:
+       unsigned long uninitialized_var(flags);

Special-case uninitialized_var() to prevent this.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Tested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/7db7944761b0bd88c70eb17d4b7f40fe589e14ed.camel@perches.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 50c92900

scripts/checkpatch.pl

+9 −5
Original line number Diff line number Diff line
@@ -4071,7 +4071,7 @@ sub process { 
		}



# check for function declarations without arguments like "int foo()"

		if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {

		if ($line =~ /(\b$Type\s*$Ident)\s*\(\s*\)/) {

			if (ERROR("FUNCTION_WITHOUT_ARGS",

				  "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&

			    $fix) {
@@ -6287,13 +6287,17 @@ sub process { 
		}



# check for function declarations that have arguments without identifier names

# while avoiding uninitialized_var(x)

		if (defined $stat &&

		    $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s &&

		    $1 ne "void") {

			my $args = trim($1);

		    $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:($Ident)|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s &&

		    (!defined($1) ||

		     (defined($1) && $1 ne "uninitialized_var")) &&

		     $2 ne "void") {

			my $args = trim($2);

			while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {

				my $arg = trim($1);

				if ($arg =~ /^$Type$/ && $arg !~ /enum\s+$Ident$/) {

				if ($arg =~ /^$Type$/ &&

					$arg !~ /enum\s+$Ident$/) {

					WARN("FUNCTION_ARGUMENTS",

					     "function definition argument '$arg' should also have an identifier name\n" . $herecurr);

				}

CRA Git | Maintained and supported by SUSTech CRA and CCSE