Commit 16abd2a0 authored Sep 16, 2020 by Olga Kornievskaia Committed by Trond Myklebust Sep 16, 2020

NFSv4.2: fix client's attribute cache management for copy_file_range



After client is done with the COPY operation, it needs to invalidate
its pagecache (as it did no reading or writing of the data locally)
and it needs to invalidate it's attributes just like it would have
for a read on the source file and write on the destination file.

Once the linux server started giving out read delegations to
read+write opens, the destination file of the copy_file range
started having delegations and not doing syncup on close of the
file leading to xfstest failures for generic/430,431,432,433,565.

v2: changing cache_validity needs to be protected by the i_lock.

Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
Fixes: 2e72448b ("NFS: Add COPY nfs operation")
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent d33030e2

fs/nfs/nfs42proc.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -356,7 +356,15 @@ static ssize_t _nfs42_proc_copy(struct file *src,

		truncate_pagecache_range(dst_inode, pos_dst,
		pos_dst + res->write_res.count);

		spin_lock(&dst_inode->i_lock);
		NFS_I(dst_inode)->cache_validity \|= (NFS_INO_REVAL_PAGECACHE \|
		NFS_INO_REVAL_FORCED \| NFS_INO_INVALID_SIZE \|
		NFS_INO_INVALID_ATTR \| NFS_INO_INVALID_DATA);
		spin_unlock(&dst_inode->i_lock);
		spin_lock(&src_inode->i_lock);
		NFS_I(src_inode)->cache_validity \|= (NFS_INO_REVAL_PAGECACHE \|
		NFS_INO_REVAL_FORCED \| NFS_INO_INVALID_ATIME);
		spin_unlock(&src_inode->i_lock);
		status = res->write_res.count;
		out:
		if (args->sync)

Admin message