Commit 16a50b12 authored Jun 27, 2012 by Tomas Winkler Committed by Greg Kroah-Hartman Jul 10, 2012

mei: pci_resume: set IRQF_ONESHOT for msi request_threaded_irq



when the default irq quick handler is used then IRQF_ONESHOT must be set
otherwise the request fails and following error is displayed:

mei 0000:00:16.0: irq 48 for MSI/MSI-X
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 48
mei 0000:00:16.0: request_threaded_irq failed: irq = 48.
dpm_run_callback(): pci_pm_resume+0x0/0x140 returns -22
PM: Device 0000:00:16.0 failed to resume async: error -22

Reported-by: Peter Wu <lekensteyn@gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Tested-by: Peter Wu <lekensteyn@gmail.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable <stable@vger.kernel.org> # 3.5
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent bd0a521e

drivers/misc/mei/main.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device)
	err = request_threaded_irq(pdev->irq,		err = request_threaded_irq(pdev->irq,
	NULL,		NULL,
	mei_interrupt_thread_handler,		mei_interrupt_thread_handler,
	0, mei_driver_name, dev);		IRQF_ONESHOT, mei_driver_name, dev);
	else		else
	err = request_threaded_irq(pdev->irq,		err = request_threaded_irq(pdev->irq,
	mei_interrupt_quick_handler,		mei_interrupt_quick_handler,

Admin message