Commit 167c25e4 authored Nov 10, 2010 by Jason Wang Committed by David S. Miller Nov 12, 2010

virtio-net: init link state correctly



For device that supports VIRTIO_NET_F_STATUS, there's no need to
assume the link is up and we need to call nerif_carrier_off() before
querying device status, otherwise we may get wrong operstate after
diver was loaded because the link watch event was not fired as
expected.

For device that does not support VIRITO_NET_F_STATUS, we could not get
its status through virtnet_update_status() and what we can only do is
always assuming the link is up.

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 75e60474

drivers/net/virtio_net.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -986,9 +986,15 @@ static int virtnet_probe(struct virtio_device *vdev)
		goto unregister;
		}

		vi->status = VIRTIO_NET_S_LINK_UP;
		/* Assume link up if device can't report link status,
		otherwise get link status from config. */
		if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_STATUS)) {
		netif_carrier_off(dev);
		virtnet_update_status(vi);
		} else {
		vi->status = VIRTIO_NET_S_LINK_UP;
		netif_carrier_on(dev);
		}

		pr_debug("virtnet: registered device %s\n", dev->name);
		return 0;

Admin message