drm/mediatek: mtk_drm_drv.c: Add of_node_put() before goto (165d42c0) · Commits · 戴 / test

Each iteration of for_each_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto in two places. Issue found with Coccinelle. Fixes: (drm/mediatek: Add DRM Driver for Mediatek SoC MT8173) Signed-off-by:

Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by:

CK Hu <ck.hu@mediatek.com>

drivers/gpu/drm/mediatek/mtk_drm_drv.c

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -567,12 +567,15 @@ static int mtk_drm_probe(struct platform_device *pdev)
	comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL);		comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL);
	if (!comp) {		if (!comp) {
	ret = -ENOMEM;		ret = -ENOMEM;
			of_node_put(node);
	goto err_node;		goto err_node;
	}		}

	ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL);		ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL);
	if (ret)		if (ret) {
			of_node_put(node);
	goto err_node;		goto err_node;
			}

	private->ddp_comp[comp_id] = comp;		private->ddp_comp[comp_id] = comp;
	}		}

Admin message